Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9108 Common components for React search header and empty text #896

Merged
merged 10 commits into from
Jan 30, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 25, 2024

UHF-9108 & UHF-9112

What was done

  • Created two new common components: ResultsHeader and ResultsEmpty
  • Refactored the following searches to use the new components:
    • District and project search
    • Health station search
    • Job search
    • Linked events
    • Maternity and child health clinics search
    • School search

How to install

How to test

  • Go to check each of the searches listed above. Make sure the search still works as it should and make sure the results title looks similar on all searches and uses the same html-elements.
  • Check that the terms on the searches are according to this list:
  • School search in KASKO:
    1 koulu / X koulua | 1 skola / X skolor | 1 school / X schools
  • District and project search in KYMP:
    1 hakutulos / X hakutulosta | 1 träff / X träffar | 1 search result / X search results
  • Job search in REKRY:
    1 avoin työpaikka (X ilmoitusta) / X avointa työpaikkaa (X ilmoitusta) | 1 lediga jobb (1 annons) / X lediga jobb (X annons) | 1 open position (x job listings) / open positions (X job listings)
  • Health station search in SOTE:
    1 terveysasema / X terveysasemaa | 1 hälsostation / X hälsostation | 1 health station / X health stations
  • Maternity and child health clinics search in SOTE:
    1 neuvola / X neuvolaa | 1 rådgivningsbyrå / X rådgivningsbyråer | 1 clinic / X clinics
  • Linked events:
    1 tapahtuma / X tapahtumaa | 1 evenemang / X evenemang | 1 event / X events
  • Check that if there is 0 results the result title and text is the same in all searches in three languages:
  • fi:
    Ei hakutuloksia
    Antamillasi valinnoilla ei löytynyt tuloksia. Voit kokeilla muuttaa hakuehtojasi.
  • sv:
    Inga sökresultat
    Med dina val hittades inga resultat. Du kan försöka ändra dina sökvillkor.
  • en:
    No results
    No results were found for the criteria you entered. Try changing your search criteria.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@teroelonen teroelonen marked this pull request as ready for review January 25, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants