Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8810: Moved variables to header class #1210

Merged
merged 3 commits into from
Mar 4, 2025
Merged

UHF-8810: Moved variables to header class #1210

merged 3 commits into from
Mar 4, 2025

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Mar 4, 2025 •
edited by teroelonen
Loading

UHF-8810

What was done

  • Changed header to use variables for padding top instead of 114px

How to install

  • Make sure your instance is up and running on latest dev branch. Test for example in etusicu
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8810
  • Run make drush-cr

How to test

  • Make sure that the branding height and language block height are still the same
  • Make sure that the padding on header class work and that content is visible in mobile
  • Make sure that for example .header-branding gets the --branding-height still correctly
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

teroelonen
teroelonen approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice 🦖

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1210/html_report/

@annadruid annadruid merged commit 1f0a3c7 into main Mar 4, 2025
2 checks passed
@annadruid annadruid deleted the UHF-8810 branch March 4, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annadruid @teroelonen