Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11330: Fixed result card logic #1191

Merged
merged 1 commit into from
Feb 18, 2025
Merged

UHF-11330: Fixed result card logic #1191

merged 1 commit into from
Feb 18, 2025

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Feb 14, 2025

UHF-11330

What was done

  • Fixed issue where string and array were compared with each other
  • I couldn't reproduce the issue in local environment described in the ticket but this should fix the issue also in production

How to install

  • Make sure your REKRY instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11330
  • Run make drush-cr

How to test

  • Go to https://helfi-rekry.docker.so/fi/avoimet-tyopaikat/etsi-avoimia-tyopaikkoja and make sure that for example when selecting the results should all be in Finnish but if there is a listing that is only in swedish it should be visible Screenshot 2025-02-14 at 14 18 02
  • If you don't have any job listings visible in your local, run drush sapi-rt; drush sapi-c; drush sapi-i; drush cr
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1191/html_report/

Copy link
Contributor

@jeremysteerio jeremysteerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants