Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Linters and updates, without sass update #1190

Merged
merged 16 commits into from
Feb 18, 2025
Merged

UHF-X Linters and updates, without sass update #1190

merged 16 commits into from
Feb 18, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 14, 2025 •
edited
Loading

UHF-X

What was done

  • Move devDependencies to dependencies
  • Update some of the dependencies but not sass since it should be done in a separate ticket.
  • Fixing javascript issues pointed out by the linter.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_linters_and_updates
  • Run make drush-cr

How to test

  • Basically make sure that closable surveys, tabs and all the react searches still work correctly after the linter fixes or at least the ones that had direct changes: School search in KASKO, News archive in Etusivu, Ploughing schedule in KYMP, Event search in Etusivu Helsinki lähelläsi section and Event block in any landing page.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@khalima khalima marked this pull request as ready for review February 17, 2025 11:22
khalima
khalima reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kasko school search and Kymp ploughing schedule works just like before. I approve those changes. 🚀

@github-actions GitHub Actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1190/html_report/

annadruid
annadruid approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely in Etusivu!

jeremysteerio
jeremysteerio reviewed Feb 17, 2025
View reviewed changes
src/js/closable-surveys.js Outdated
@@ -1,7 +1,7 @@
import LocalStorageManager from './localStorageManager';

// eslint-disable-next-line func-names
(function (Drupal) {
((Drupal) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant parentheses (no need to wrap Drupal

src/js/closable-surveys.js Outdated
@@ -30,6 +30,7 @@ import LocalStorageManager from './localStorageManager';
try {
surveysToHide = JSON.parse(window.localStorage.getItem('helfi-settings'));
} catch (e) {
// eslint-disable-next-line no-console
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we tweak the rules to allow these? I think we're using console.error and capturing these to Sentry

@github-actions GitHub Actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1190/html_report/

@github-actions GitHub Actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1190/html_report/

@github-actions GitHub Actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1190/html_report/

@teroelonen teroelonen merged commit 84e25eb into main Feb 18, 2025
2 checks passed
@teroelonen teroelonen deleted the UHF-X_linters_and_updates branch February 18, 2025 14:49
This was referenced Feb 18, 2025
Merged
Merged
Merged
This was referenced Feb 18, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima left review comments

@jeremysteerio jeremysteerio jeremysteerio approved these changes

@annadruid annadruid annadruid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teroelonen @khalima @jeremysteerio @annadruid