Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Fix conditional that caused location filter to pop up unexpetedly #1189

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

jeremysteerio
Copy link
Contributor

Fix conditional that caused location filter to pop up unexpetedly

What was done

Fix ternary operator to work properly

How to install

  • Set up Etusivu instance
  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X-fix-location-filter-conditional
  • Run make drush-cr

How to test

  • Add a landing page with event paragraph
    • Check that location filter doesn't show up when you select "show event time filter"
    • Check that location filter shows up when you select "show event location filter"
  • Go to Near you events page
    • Check that events location filter shows up

Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1189/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants