Tan 3487/screening status filter item #9994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enLabDotCo/citizenlab into TAN-3487/screening-status-filter-item
…into TAN-3487/screening-status-filter-item
|
brentguf
commented
Jan 8, 2025
Comment on lines
+65
to
+69
| const prescreeningButtonIsDisabled = | ||
| !phasePrescreeningEnabled || !preScreeningFeatureAllowed; | ||
|
|
||
| const prescreeningTooltipIsDisabled = | ||
| phasePrescreeningEnabled && preScreeningFeatureAllowed; |
There was a problem hiding this comment.
I've removed the status code checks here since we know code is always prescreening.
brentguf
commented
Jan 8, 2025
There was a problem hiding this comment.
This is the original StatusFilter with all the prescreening status related code that I'd like to separate from all other status filters. Only changes where indicated. :)
brentguf
commented
Jan 8, 2025
There was a problem hiding this comment.
Removed all prescreening specific code from this.
…into TAN-3487/screening-status-filter-item
IvaKop
reviewed
Jan 9, 2025
...app/components/admin/PostManager/components/FilterSidebar/statuses/ScreeningStatusFilter.tsx
Outdated
Show resolved
Hide resolved
...app/components/admin/PostManager/components/FilterSidebar/statuses/ScreeningStatusFilter.tsx
Outdated
Show resolved
Hide resolved
...app/components/admin/PostManager/components/FilterSidebar/statuses/ScreeningStatusFilter.tsx
Outdated
Show resolved
Hide resolved
front/app/components/admin/PostManager/components/FilterSidebar/statuses/StatusFilters.tsx
Show resolved
Hide resolved
Merged
Tan 3487/review
…into TAN-3487/screening-status-filter-item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of code specifically for status code
prescreeningin the generic status filter, which makes it hard to reason about/messy. So I'm creating a separate component for theprescreeningstatus code to take this out.This is prep work for next ticket(s). No functional changes in here. I might further refactor this (reduce code duplication) later if I have time left.
Changelog
Changed
Screeningstatus in input manager so it doesn't look as if you can drop inputs on this status.