Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAN-3502: Add logic to multi and image select #10011

Conversation

EdwinKato
Copy link
Contributor

Changelog

Added

  • Add logic to multi and image select field types

Copy link

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Jan 10, 2025

Messages
📖 Changelog provided 🎉
📖 Notion issue: TAN-3502
📖

Run the e2e tests

📖 Check translation progress

Generated by 🚫 dangerJS against bd8385f

@EdwinKato EdwinKato changed the base branch from master to TAN-3497-logic-for-any-and-no-answer January 10, 2025 08:35
@EdwinKato EdwinKato requested a review from jamesspeake January 10, 2025 10:17
@EdwinKato EdwinKato marked this pull request as ready for review January 13, 2025 10:55
Copy link
Contributor

@jamesspeake jamesspeake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to work well. But I think we need to add to the warning text on the field so users understand what happens on conflict. Maybe something like:

"If no logic is added to an answer, the survey will follow its normal flow. If a user selects more than one option that has logic applied then the survey flow will always move onto the last page from those logic options."

I do think it is slightly counter intuitive as it should probably go to the earliest but it would require a big rework to get it to do that.

@EdwinKato
Copy link
Contributor Author

Looks good and seems to work well. But I think we need to add to the warning text on the field so users understand what happens on conflict. Maybe something like:

"If no logic is added to an answer, the survey will follow its normal flow. If a user selects more than one option that has logic applied then the survey flow will always move onto the last page from those logic options."

I do think it is slightly counter intuitive as it should probably go to the earliest but it would require a big rework to get it to do that.

Agreed, handling logic conflict warnings in a separate PR

@EdwinKato EdwinKato merged commit 7a61b49 into TAN-3497-logic-for-any-and-no-answer Jan 14, 2025
16 checks passed
@EdwinKato EdwinKato deleted the TAN-3502-add-logic-to-multi-and-image-select branch January 14, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants