Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAN-3497 - Add 'any_other_answer' as a logic option #10009

Open
wants to merge 26 commits into
base: TAN-3498-make-fields-with-logic-optional
Choose a base branch
from
Open

TAN-3497 - Add 'any_other_answer' as a logic option #10009

wants to merge 26 commits into from
+458 −115

Conversation

jamesspeake
Copy link
Contributor

@jamesspeake jamesspeake commented Jan 8, 2025 •
edited
Loading

Changelog

Added

  • 'Any other answer' can be added as a catch-all logic option in a survey form select or linear scale field
  • 'Not answered' can be added as a catch-all logic option for non-required survey form select or linear scale field

@notion-workspace Notion Workspace
Copy link

Add survey logic options for ‘any other answer’ and ‘no answer’

@jamesspeake jamesspeake changed the title [TAN-3497 - Add 'any_other_answer' as a logic option TAN-3497 - Add 'any_other_answer' as a logic option Jan 8, 2025
@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Jan 8, 2025 •
edited
Loading

Messages
📖 Changelog provided 🎉
📖 Notion issue: TAN-3497
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 4d9bc62

@jamesspeake jamesspeake changed the base branch from master to TAN-3498-make-fields-with-logic-optional January 8, 2025 17:01
jamesspeake and others added 17 commits January 8, 2025 17:10
@jamesspeake
[TAN-3497] Changed the message
cc7a48e
Translations updated by CI (extract-intl)
2f7bd72
@jamesspeake
[TAN-3497] Made side panel clearer
d88a54e
@jamesspeake
Merge remote-tracking branch 'origin/TAN-3497-logic-for-any-and-no-an…
93f7d8d 
…swer' into TAN-3497-logic-for-any-and-no-answer
Translations updated by CI (extract-intl)
b3dd137
@jamesspeake
[TAN-3497] Linting fix
3b82d90
@jamesspeake
Merge remote-tracking branch 'origin/TAN-3497-logic-for-any-and-no-an…
d52ee68 
…swer' into TAN-3497-logic-for-any-and-no-answer
@jamesspeake
[TAN-3497] Fixed linear scale 'any_other_answer'
a5921fe
@EdwinKato
Add handling for 'no_answer' in visibility condition evaluation
7545c7f
@jamesspeake
[TAN-3497] Fixed order of rules view + fixed page logic overriding qu…
9903d9b 
…estion logic
@jamesspeake
[TAN-3497] Updated logic message
f3f61af
Translations updated by CI (extract-intl)
f98c719
@jamesspeake
[TAN-3497] Fixed required turning back on when logic removed
73aa0f6
@jamesspeake
Merge remote-tracking branch 'origin/TAN-3497-logic-for-any-and-no-an…
f249c11 
…swer' into TAN-3497-logic-for-any-and-no-answer
Translations updated by CI (extract-intl)
42ded5c
@jamesspeake
[TAN-3497] Fixed no_answer not respecting page level logic + removed …
934e45e 
…no_answer logic if required
@jamesspeake
[TAN-3497] Fixed rubocop complexity
4b1f081
@jamesspeake jamesspeake marked this pull request as ready for review January 9, 2025 18:20
@jamesspeake jamesspeake requested a review from EdwinKato January 9, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwinKato EdwinKato Awaiting requested review from EdwinKato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mini cycle survey improvements
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesspeake @cl-dev-bot @EdwinKato