Skip to content

Commit

Permalink
Merge pull request #149 from CiscoISE/develop
Browse files Browse the repository at this point in the history
Develop
  • Loading branch information
bvargasre authored Nov 21, 2024
2 parents edb760a + b2c839f commit 21101ff
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 14 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ The following table shows the supported versions.
| 3.1.0 | 2.0.0 | 1.2.0 |
| 3.1_Patch_1 | 2.5.16 | 2.0.10 |
| 3.2_beta | 2.8.0 | 2.1.1 |
| 3.3_patch_1 | 2.9.3 | 2.2.3 |
| 3.3_patch_1 | 2.9.6 | 2.2.3 |

If your Ansible collection is older please consider updating it first.
*Notes*:
Expand Down
8 changes: 7 additions & 1 deletion changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1040,4 +1040,10 @@ releases:
changes:
release_summary: Update.
bugfixes:
- cisco.ise.support_bundle_download keeps failing after downloading the file
- cisco.ise.support_bundle_download keeps failing after downloading the file
2.9.6:
release_date: "2024-11-21"
changes:
release_summary: Update network_device module.
bugfixes:
- network_device - Fix mask validation to handle None values in NetworkDeviceIPList
2 changes: 1 addition & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
namespace: cisco
name: ise
version: 2.9.5
version: 2.9.6
readme: README.md
authors:
- Rafael Campos <[email protected]>
Expand Down
23 changes: 12 additions & 11 deletions plugins/action/network_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,19 @@ class NetworkDevice(object):
def __init__(self, params, ise):
self.ise = ise
network_device_iplist = params.get("NetworkDeviceIPList", [])
# Ensure mask is always an integer
for ip in network_device_iplist:
try:
if isinstance(ip.get("mask"), str):
ip["mask"] = int(ip["mask"])
except ValueError:
self.ise.fail_json(
msg=(
"The mask value for the IP address is not an integer."
" Please provide a valid integer value."
if network_device_iplist is not None:
# Ensure mask is always an integer
for ip in network_device_iplist:
try:
if isinstance(ip.get("mask"), str):
ip["mask"] = int(ip["mask"])
except ValueError:
self.ise.fail_json(
msg=(
"The mask value for the IP address is not an integer."
" Please provide a valid integer value."
)
)
)
self.new_object = dict(
name=params.get("name"),
description=params.get("description"),
Expand Down

0 comments on commit 21101ff

Please sign in to comment.