Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX2.0] Resolve Issue #380 #385

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[UX2.0] Resolve Issue #380 #385

merged 1 commit into from
Jan 9, 2025

Conversation

seconroy
Copy link
Collaborator

@seconroy seconroy commented Jan 2, 2025 •
edited
Loading

Description

Resolves Issues #380

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy changed the title [UX2.0] RResolve issue #380 [UX2.0] Resolve Issue #380 Jan 2, 2025
@seconroy seconroy requested a review from tzarski0 January 6, 2025 11:33
tzarski0
tzarski0 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@tzarski0 tzarski0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the code changes made, example data works as expected now.

@seconroy seconroy requested a review from danischm January 7, 2025 11:42
@danischm danischm merged commit 5ce26d3 into CiscoDevNet:main Jan 9, 2025
3 checks passed
@danischm danischm deleted the resolve-issue-23 branch January 9, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarski0 tzarski0 tzarski0 approved these changes

@danischm danischm danischm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seconroy @danischm @tzarski0