Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX2.0] Adds Service DHCP Server Resource and Data Source #375

Merged
merged 10 commits into from
Nov 29, 2024
Merged

[UX2.0] Adds Service DHCP Server Resource and Data Source #375

merged 10 commits into from
Nov 29, 2024

Conversation

seconroy
Copy link
Collaborator

@seconroy seconroy commented Nov 27, 2024 •
edited
Loading

Description

Adds Service DHCP Server Resource and Data Source and Update Documentation Categories

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy requested a review from tzarski0 November 27, 2024 12:31
tzarski0
tzarski0 reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@tzarski0 tzarski0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks OK, just one comment if we should also add DHCP server association to other features like sdwan_service_lan_vpn_interface_ipsec_feature and sdwan_service_lan_vpn_interface_svi_feature?

gen/definitions/generic/service_lan_vpn_ethernet_interface_feature_associate_dhcp_server.yaml Show resolved Hide resolved
@danischm danischm merged commit 64a3989 into CiscoDevNet:main Nov 29, 2024
3 checks passed
@danischm danischm deleted the dhcp-server branch November 29, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarski0 tzarski0 tzarski0 left review comments

@danischm danischm danischm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seconroy @danischm @tzarski0