Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Issue #364 #368

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Resolve Issue #364 #368

merged 2 commits into from
Nov 21, 2024

Conversation

seconroy
Copy link
Collaborator

Description

Resolves Issues #364

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy requested a review from tzarski0 November 15, 2024 09:39
danischm
danischm requested changes Nov 18, 2024
View reviewed changes
gen/templates/profile_parcels/model.go Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
tzarski0
tzarski0 reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@tzarski0 tzarski0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seconroy I think same fix for port is required in the sdwan_system_ipv4_device_access_feature and sdwan_system_ipv6_device_access_feature

@tzarski0
Copy link
Collaborator

My bad, this fix not required in sdwan_system_ipv4_device_access_feature and sdwan_system_ipv6_device_access_feature.

@danischm danischm merged commit 220696f into CiscoDevNet:main Nov 21, 2024
3 checks passed
@danischm danischm deleted the acl-port-fix branch November 21, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarski0 tzarski0 tzarski0 left review comments

@danischm danischm danischm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seconroy @tzarski0 @danischm