Resolve bugs #119 and #120

CHANGELOG.md

@@ -7,6 +7,8 @@
 - Add `sdwan_system_aaa_profile_parcel` resource and data source
 - Add `sdwan_system_banner_profile_parcel` resource and data source
 - Add `sdwan_system_bfd_profile_parcel` resource and data source
+- BREAKING CHANGE: convert `protocol`, `source_port`, `destination_port` attribute of `sdwan_traffic_data_policy_definition` to Strings to support multiple values
+- Fix issue with `sdwan_traffic_data_policy_definition` not supporting local and restrict options
 
 ## 0.2.11
 

docs/data-sources/traffic_data_policy_definition.md

@@ -102,6 +102,8 @@ Read-Only:
 - `service_tloc_ip` (String) Service TLOC IP address
 - `service_tloc_list_id` (String) Service TLOC list ID
 - `service_tloc_list_version` (Number) Service TLOC list version
+- `service_tloc_local` (String) Service TLOC Local, Any value (including an empty string) will enable this feature
+- `service_tloc_restrict` (String) Service TLOC Restrict, Any value (including an empty string) will enable this feature
 - `service_type` (String) Service type
 - `service_vpn_id` (Number) Service VPN ID
 - `tloc_color` (String) TLOC color
@@ -124,19 +126,19 @@ Read-Only:
 - `destination_data_prefix_list_id` (String) Destination Data Prefix list ID
 - `destination_data_prefix_list_version` (Number) Destination Data Prefix list version
 - `destination_ip` (String) Destination IP
-- `destination_port` (Number) Destination port
+- `destination_port` (String) Destination port, 0-65535 (Single value, range or multiple values separated by spaces)
 - `destination_region` (String) Destination region
 - `dns` (String) DNS request or response
 - `dns_application_list_id` (String) DNS Application list ID
 - `dns_application_list_version` (Number) DNS Application list version
 - `dscp` (Number) DSCP value
 - `packet_length` (Number) Packet length
 - `plp` (String) PLP
-- `protocol` (Number) IP Protocol
+- `protocol` (String) IP Protocol, 0-255 (Single value or multiple values separated by spaces)
 - `source_data_prefix_list_id` (String) Source Data Prefix list ID
 - `source_data_prefix_list_version` (Number) Source Data Prefix list version
 - `source_ip` (String) Source IP
-- `source_port` (Number) Source port
+- `source_port` (String) Source port, 0-65535 (Single value, range or multiple values separated by spaces)
 - `tcp` (String) TCP flags
 - `traffic_to` (String) Traffic to
 - `type` (String) Type of match entry

docs/guides/changelog.md

@@ -16,6 +16,8 @@ description: |-
 - Add `sdwan_system_aaa_profile_parcel` resource and data source
 - Add `sdwan_system_banner_profile_parcel` resource and data source
 - Add `sdwan_system_bfd_profile_parcel` resource and data source
+- BREAKING CHANGE: convert `protocol`, `source_port`, `destination_port` attribute of `sdwan_traffic_data_policy_definition` to Strings to support multiple values
+- Fix issue with `sdwan_traffic_data_policy_definition` not supporting local and restrict options
 
 ## 0.2.11
 

docs/resources/traffic_data_policy_definition.md

@@ -158,6 +158,8 @@ Optional:
 - `service_tloc_ip` (String) Service TLOC IP address
 - `service_tloc_list_id` (String) Service TLOC list ID
 - `service_tloc_list_version` (Number) Service TLOC list version
+- `service_tloc_local` (String) Service TLOC Local, Any value (including an empty string) will enable this feature
+- `service_tloc_restrict` (String) Service TLOC Restrict, Any value (including an empty string) will enable this feature
 - `service_type` (String) Service type
   - Choices: `FW`, `IDP`, `IDS`, `netsvc1`, `netsvc2`, `netsvc3`, `netsvc4`, `netsvc5`
 - `service_vpn_id` (Number) Service VPN ID
@@ -188,8 +190,7 @@ Optional:
 - `destination_data_prefix_list_id` (String) Destination Data Prefix list ID
 - `destination_data_prefix_list_version` (Number) Destination Data Prefix list version
 - `destination_ip` (String) Destination IP
-- `destination_port` (Number) Destination port
-  - Range: `0`-`65535`
+- `destination_port` (String) Destination port, 0-65535 (Single value, range or multiple values separated by spaces)
 - `destination_region` (String) Destination region
   - Choices: `primary-region`, `secondary-region`, `other-region`
 - `dns` (String) DNS request or response
@@ -202,13 +203,11 @@ Optional:
   - Range: `0`-`65535`
 - `plp` (String) PLP
   - Choices: `low`, `high`
-- `protocol` (Number) IP Protocol
-  - Range: `0`-`255`
+- `protocol` (String) IP Protocol, 0-255 (Single value or multiple values separated by spaces)
 - `source_data_prefix_list_id` (String) Source Data Prefix list ID
 - `source_data_prefix_list_version` (Number) Source Data Prefix list version
 - `source_ip` (String) Source IP
-- `source_port` (Number) Source port
-  - Range: `0`-`65535`
+- `source_port` (String) Source port, 0-65535 (Single value, range or multiple values separated by spaces)
 - `tcp` (String) TCP flags
   - Choices: `syn`
 - `traffic_to` (String) Traffic to

gen/definitions/generic/traffic_data_policy_definition.yaml

@@ -107,6 +107,7 @@ attributes:
             type: String
             description: Application list ID
             example: e3aad846-abb9-425f-aaa8-9ed17b9c8d7c
+            test_value: sdwan_application_list_policy_object.test.id
           - tf_name: application_list_version
             tf_only: true
             type: Version
@@ -175,11 +176,8 @@ attributes:
             conditional_attribute:
               name: type
               value: protocol
-            type: Int64
-            model_type_string: true
-            description: IP Protocol
-            min_int: 0
-            max_int: 255
+            type: String
+            description: IP Protocol, 0-255 (Single value or multiple values separated by spaces)
             example: 10
             exclude_test: true
           - model_name: ref
@@ -210,11 +208,8 @@ attributes:
             conditional_attribute:
               name: type
               value: sourcePort
-            type: Int64
-            model_type_string: true
-            description: Source port
-            min_int: 0
-            max_int: 65535
+            type: String
+            description: Source port, 0-65535 (Single value, range or multiple values separated by spaces)
             example: 10
             exclude_test: true
           - model_name: ref
@@ -245,11 +240,8 @@ attributes:
             conditional_attribute:
               name: type
               value: destinationPort
-            type: Int64
-            model_type_string: true
-            description: Destination port
-            min_int: 0
-            max_int: 65535
+            type: String
+            description: Destination port, 0-65535 (Single value, range or multiple values separated by spaces)
             example: 100
             exclude_test: true
           - model_name: value
@@ -699,6 +691,26 @@ attributes:
                 description: Service TLOC IP address
                 example: 1.2.3.4
                 exclude_test: true
+              - model_name: local
+                data_path: [value]
+                tf_name: service_tloc_local
+                conditional_attribute:
+                  name: type
+                  value: service
+                type: String
+                description: Service TLOC Local, Any value (including an empty string) will enable this feature
+                example: ""
+                exclude_test: true
+              - model_name: restrict
+                data_path: [value]
+                tf_name: service_tloc_restrict
+                conditional_attribute:
+                  name: type
+                  value: service
+                type: String
+                description: Service TLOC Restrict, Any value (including an empty string) will enable this feature
+                example: ""
+                exclude_test: true
               - model_name: color
                 data_path: [value, tloc]
                 tf_name: service_tloc_color
@@ -772,3 +784,13 @@ attributes:
                 description: Fallback
                 example: true
                 exclude_test: true
+
+test_prerequisites: |
+  resource "sdwan_application_list_policy_object" "test" {
+    name = "TF_TEST"
+    entries = [
+      {
+        application = "netflix"
+      }
+    ]
+  }