Add base action attribute to traffic data policy definition

CiscoDevNet · Nov 22, 2023 · 5856d6a · 5856d6a
1 parent 83cada6
commit 5856d6a
Show file tree

Hide file tree

Showing 12 changed files with 49 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 - Fix idempotency issue with various resource and boolean values
 - Remove redundant `per_tunnel_qos` and `per_tunnel_qos_aggregator` attributes from `sdwan_cisco_vpn_interface_feature_template` resource and data source
 - Add `base_action` attribute to `sdwan_custom_control_topology_policy_definition` resource and data source
+- Add `base_action` attribute to `sdwan_traffic_data_policy_definition` resource and data source
 
 ## 0.2.10
 

diff --git a/docs/data-sources/traffic_data_policy_definition.md b/docs/data-sources/traffic_data_policy_definition.md
@@ -39,6 +39,7 @@ data "sdwan_traffic_data_policy_definition" "example" {
 Read-Only:
 
 - `action_entries` (Attributes List) List of action entries (see [below for nested schema](#nestedatt--sequences--action_entries))
+- `base_action` (String) Base action, either `accept` or `drop`
 - `id` (Number) Sequence ID
 - `ip_type` (String) Sequence IP type, either `ipv4`, `ipv6` or `all`
 - `match_entries` (Attributes List) List of match entries (see [below for nested schema](#nestedatt--sequences--match_entries))

diff --git a/docs/guides/changelog.md b/docs/guides/changelog.md
@@ -12,6 +12,7 @@ description: |-
 - Fix idempotency issue with various resource and boolean values
 - Remove redundant `per_tunnel_qos` and `per_tunnel_qos_aggregator` attributes from `sdwan_cisco_vpn_interface_feature_template` resource and data source
 - Add `base_action` attribute to `sdwan_custom_control_topology_policy_definition` resource and data source
+- Add `base_action` attribute to `sdwan_traffic_data_policy_definition` resource and data source
 
 ## 0.2.10
 

diff --git a/docs/resources/traffic_data_policy_definition.md b/docs/resources/traffic_data_policy_definition.md
@@ -19,10 +19,11 @@ resource "sdwan_traffic_data_policy_definition" "example" {
   default_action = "drop"
   sequences = [
     {
-      id      = 1
-      name    = "Seq1"
-      type    = "applicationFirewall"
-      ip_type = "ipv4"
+      id          = 1
+      name        = "Seq1"
+      type        = "applicationFirewall"
+      ip_type     = "ipv4"
+      base_action = "accept"
       match_entries = [
         {
           type                = "appList"
@@ -72,6 +73,8 @@ Required:
 Optional:
 
 - `action_entries` (Attributes List) List of action entries (see [below for nested schema](#nestedatt--sequences--action_entries))
+- `base_action` (String) Base action, either `accept` or `drop`
+  - Choices: `accept`, `drop`
 - `ip_type` (String) Sequence IP type, either `ipv4`, `ipv6` or `all`
   - Choices: `ipv4`, `ipv6`, `all`
 - `match_entries` (Attributes List) List of match entries (see [below for nested schema](#nestedatt--sequences--match_entries))

diff --git a/examples/resources/sdwan_traffic_data_policy_definition/resource.tf b/examples/resources/sdwan_traffic_data_policy_definition/resource.tf
@@ -4,10 +4,11 @@ resource "sdwan_traffic_data_policy_definition" "example" {
   default_action = "drop"
   sequences = [
     {
-      id      = 1
-      name    = "Seq1"
-      type    = "applicationFirewall"
-      ip_type = "ipv4"
+      id          = 1
+      name        = "Seq1"
+      type        = "applicationFirewall"
+      ip_type     = "ipv4"
+      base_action = "accept"
       match_entries = [
         {
           type                = "appList"

diff --git a/gen/definitions/generic/traffic_data_policy_definition.yaml b/gen/definitions/generic/traffic_data_policy_definition.yaml
@@ -61,6 +61,12 @@ attributes:
         enum_values: [ipv4, ipv6, all]
         description: Sequence IP type, either `ipv4`, `ipv6` or `all`
         example: ipv4
+      - model_name: baseAction
+        tf_name: base_action
+        type: String
+        enum_values: [accept, drop]
+        description: Base action, either `accept` or `drop`
+        example: accept
       - model_name: entries
         data_path: [match]
         tf_name: match_entries

diff --git a/internal/provider/data_source_sdwan_traffic_data_policy_definition.go b/internal/provider/data_source_sdwan_traffic_data_policy_definition.go
diff --git a/internal/provider/data_source_sdwan_traffic_data_policy_definition_test.go b/internal/provider/data_source_sdwan_traffic_data_policy_definition_test.go
diff --git a/internal/provider/model_sdwan_traffic_data_policy_definition.go b/internal/provider/model_sdwan_traffic_data_policy_definition.go
diff --git a/internal/provider/resource_sdwan_traffic_data_policy_definition.go b/internal/provider/resource_sdwan_traffic_data_policy_definition.go
diff --git a/internal/provider/resource_sdwan_traffic_data_policy_definition_test.go b/internal/provider/resource_sdwan_traffic_data_policy_definition_test.go
diff --git a/templates/guides/changelog.md.tmpl b/templates/guides/changelog.md.tmpl
@@ -12,6 +12,7 @@ description: |-
 - Fix idempotency issue with various resource and boolean values
 - Remove redundant `per_tunnel_qos` and `per_tunnel_qos_aggregator` attributes from `sdwan_cisco_vpn_interface_feature_template` resource and data source
 - Add `base_action` attribute to `sdwan_custom_control_topology_policy_definition` resource and data source
+- Add `base_action` attribute to `sdwan_traffic_data_policy_definition` resource and data source
 
 ## 0.2.10