Added parameters for BGP Address family #288
Conversation
|
I made another change. In BGP address family already done was the parameters of To address this I changed this to a string, put the proper default values and then also had to change the examples to be different than the default values or the test code would also fail. |
| default_value: "noncrit" | ||
| example: 8000 | ||
| - nxos_name: advertL2vpnEvpn | ||
| tf_name: adv_l2vpn_evpn |
There was a problem hiding this comment.
For the tf_name we try to avoid abbreviations and expand names where it makes sense. So I would suggest advertise_l2vpn_evpn.
| default_value: disabled | ||
| example: disabled | ||
| - nxos_name: advPip | ||
| tf_name: adv_phyip_for_type5_routes |
There was a problem hiding this comment.
-> advertise_physical_ip_for_type5_routes
| default_value: 1 | ||
| example: 2 | ||
| - nxos_name: maxExtEcmp | ||
| tf_name: max_ext_ecmp_paths |
| default_value: 1 | ||
| example: 1 | ||
| - nxos_name: maxExtIntEcmp | ||
| tf_name: max_ext_int_ecmp_paths |
There was a problem hiding this comment.
-> max_external_internal_ecmp_paths
| default_value: 1 | ||
| example: 1 | ||
| - nxos_name: maxLclEcmp | ||
| tf_name: max_eqcost_ecmp_paths |
| default_value: 1 | ||
| example: 1 | ||
| - nxos_name: defInfOriginate | ||
| tf_name: def_inf_originate |
There was a problem hiding this comment.
-> default_information_originate
| default_value: disabled | ||
| example: disabled | ||
| - nxos_name: supprInactive | ||
| tf_name: adv_only_act_routes |
There was a problem hiding this comment.
-> advertise_only_active_routes
| - disabled | ||
| default_value: disabled | ||
| example: disabled | ||
| - nxos_name: tblMap |
There was a problem hiding this comment.
I think the feature on the cli is name "table-map", so maybe table_map_route_map_name.
| example: ROUTE_MAP1 | ||
| default_value: "" | ||
| - nxos_name: vniEthTag | ||
| tf_name: vni_ethtag |
| default_value: disabled | ||
| example: disabled | ||
| - nxos_name: waitIgpConv | ||
| tf_name: wait_igp_conv |
Added as many of the parameters for BGP address family as I could validate in NXOS 9.3 CML instance I have. RAN tests against sandbox.