Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] Optimization through an additional api call at list-identity schema endpoint to avoid retrieval of all schemas in order to get the id of a schema (DCNE-208) #302

Conversation

akinross
Copy link
Collaborator

No description provided.

@akinross akinross force-pushed the optimize_schema_datasource_for_large_schemas branch from 8770ca1 to a4568db Compare October 15, 2024 11:09
…entity schema endpoint to avoid retrieval of all schemas in order to get the id of a schema
@akinross akinross force-pushed the optimize_schema_datasource_for_large_schemas branch from a4568db to ec71511 Compare October 15, 2024 18:39
@akinross akinross added the jira-sync Sync this issue to Jira label Oct 15, 2024
@github-actions github-actions bot changed the title [minor_change] Optimization through an additional api call at list-identity schema endpoint to avoid retrieval of all schemas in order to get the id of a schema [minor_change] Optimization through an additional api call at list-identity schema endpoint to avoid retrieval of all schemas in order to get the id of a schema (DCNE-208) Oct 15, 2024
mso/utils.go Show resolved Hide resolved
@akinross akinross requested a review from anvitha-jain October 16, 2024 06:55
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit f974b5f into CiscoDevNet:master Oct 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-sync Sync this issue to Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants