Remove mandatory attribute from groupId in endpoint resource (#49)

CiscoDevNet · Apr 18, 2024 · 35a76d5 · 35a76d5
1 parent d679c14
commit 35a76d5
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.2.1 (unreleased)
+
+- Make `groupId` attribute of `ise_endpoint` resource optional
+
 ## 0.2.0
 
 - Add `ise_endpoint` resource and data source

diff --git a/docs/guides/changelog.md b/docs/guides/changelog.md
@@ -7,6 +7,10 @@ description: |-
 
 # Changelog
 
+## 0.2.1 (unreleased)
+
+- Make `groupId` attribute of `ise_endpoint` resource optional
+
 ## 0.2.0
 
 - Add `ise_endpoint` resource and data source

diff --git a/docs/resources/endpoint.md b/docs/resources/endpoint.md
@@ -31,7 +31,6 @@ resource "ise_endpoint" "example" {
 
 ### Required
 
-- `group_id` (String) Identity Group ID
 - `mac` (String) MAC address of the endpoint
 - `name` (String) The name of the endpoint
 - `static_group_assignment` (Boolean) Static Group Assignment
@@ -41,6 +40,7 @@ resource "ise_endpoint" "example" {
 
 - `custom_attributes` (Map of String) Custom Attributes
 - `description` (String) Description
+- `group_id` (String) Identity Group ID
 - `identity_store` (String) Identity Store
 - `identity_store_id` (String) Identity Store Id
 - `mdm_compliance_status` (Boolean) Mdm Compliance Status

diff --git a/gen/definitions/endpoint.yaml b/gen/definitions/endpoint.yaml
@@ -23,7 +23,6 @@ attributes:
     example: 00:11:22:33:44:55
   - model_name: groupId
     data_path: [ERSEndPoint]
-    mandatory: true
     type: String
     description: Identity Group ID
     example: 3a88eec0-8c00-11e6-996c-525400b48521

diff --git a/internal/provider/resource_ise_endpoint.go b/internal/provider/resource_ise_endpoint.go
diff --git a/internal/provider/resource_ise_endpoint_test.go b/internal/provider/resource_ise_endpoint_test.go
diff --git a/templates/guides/changelog.md.tmpl b/templates/guides/changelog.md.tmpl
@@ -7,6 +7,10 @@ description: |-
 
 # Changelog
 
+## 0.2.1 (unreleased)
+
+- Make `groupId` attribute of `ise_endpoint` resource optional
+
 ## 0.2.0
 
 - Add `ise_endpoint` resource and data source