Deprecate relation_vz_rs_graph_at from aci_contract #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiib
force-pushed
the
deprecate_relation_vz_rs_graph_att
branch
2 times, most recently
from
e8581e3 to
0894f0f
Compare
samiib
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
gmicol
akinross
requested changes
May 28, 2024
…t` attribute from `aci_contract`. Use `relation_vz_rs_subj_graph_att` on `aci_contract_subject` instead.
samiib
force-pushed
the
deprecate_relation_vz_rs_graph_att
branch
from
0894f0f to
b35d99b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 43 43
Lines 11223 11223
=======================================
Hits 9768 9768
Misses 991 991
Partials 464 464 ☔ View full report in Codecov by Sentry. |
anvitha-jain
approved these changes
May 30, 2024
anvitha-jain
approved these changes
May 31, 2024
lhercot
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated the non-functional
relation_vz_rs_graph_atattribute fromaci_contract. Userelation_vz_rs_subj_graph_attonaci_contract_subjectinstead.Closes #1162