Add Resource and Datasource for Netflow Record Policy #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmicol
force-pushed
the
aci_netflow_record_pol
branch
from
4fcf2d0 to
3707aaf
Compare
gmicol
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
samiib
akinross
requested changes
Jun 10, 2024
gmicol
force-pushed
the
aci_netflow_record_pol
branch
from
d6e18cb to
057629c
Compare
shrsr
requested changes
Jun 17, 2024
…tributes that are slices of strings.
… Modify resource.go.tmpl to allow empty list as input. Modify test templates to check for attributes set to empty list.
…in documentation.
gmicol
force-pushed
the
aci_netflow_record_pol
branch
from
057629c to
ed80520
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
+ Coverage 87.03% 87.09% +0.05%
==========================================
Files 43 45 +2
Lines 11223 11802 +579
==========================================
+ Hits 9768 10279 +511
- Misses 991 1035 +44
- Partials 464 488 +24 ☔ View full report in Codecov by Sentry. |
anvitha-jain
previously approved these changes
Jun 18, 2024
lhercot
requested changes
Jun 19, 2024
gmicol
dismissed stale reviews from anvitha-jain, akinross, samiib, and shrsr
via
69e6f0f
anvitha-jain
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1210