Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced individual payload entries with the append_update_ops_data function in the ndo_route_map_policy_multicast module (DCNE-272) #596

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Replaced individual payload entries with the append_update_ops_data function in the ndo_route_map_policy_multicast module (DCNE-272) #596

merged 1 commit into from
Jan 22, 2025

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Jan 9, 2025

No description provided.

@shrsr shrsr self-assigned this Jan 9, 2025
@shrsr shrsr added the jira-sync Sync this issue to Jira label Jan 9, 2025
@github-actions github-actions bot changed the title Replaced individual payload entries with the append_update_ops_data function in the ndo_route_map_policy_multicast module Replaced individual payload entries with the append_update_ops_data function in the ndo_route_map_policy_multicast module (DCNE-272) Jan 9, 2025
@shrsr shrsr requested a review from sajagana January 10, 2025 18:18
akinross
akinross previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrsr shrsr dismissed stale reviews from samiib, gmicol, and akinross via 68e4f07 January 15, 2025 00:17
@shrsr shrsr requested review from gmicol, akinross and samiib January 15, 2025 00:18
@shrsr shrsr requested a review from gmicol January 20, 2025 21:30
@shrsr
[minor_change] Replaced individual payload entries with the append_up…
b5cc4c3 
…date_ops_data function in the ndo_route_map_policy_multicast module
akinross
akinross approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhercot lhercot merged commit 031f918 into CiscoDevNet:master Jan 22, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

Assignees

@shrsr shrsr

Labels
jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shrsr @lhercot @akinross @sajagana @samiib @gmicol