[minor_change] Fix BGP peer rn on non-infra peers (DCNE-294) #717
+461
−801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edudppaz
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
akinross
requested changes
Jan 22, 2025
github-actions
bot
changed the title
added 2 commits
January 24, 2025 09:13
akinross
requested changes
Jan 24, 2025
akinross
requested changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIC (tested on v5.2+) expects the rn for the PeerP and addresses on the same format as the infra bgp peer (said, enclosed by []), this also allows a prefix to be defined for BGP dynamic neighbors.
From APIC API:
Non-prefix:
Right now the URL is being built as:
uni/tn-tn_cml/out-l3out_lab-nettverk-srv_to_fw/lnodep-l3out_lab-nettverk-srv_to_fw-NP/lifp-l3out_lab-nettverk-srv_to_fw-IP/rspathL3OutAtt-[topology/pod-1/protpaths-101-102/pathep-[VPC-101_102_4]]/peerP-1.1.1.1This is accepted by the APIC but fails when trying to configure a prefix for dynamic bgp neighbors