Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Bug Fix - Left Nav Bar #6650

Merged
merged 1 commit into from
Nov 11, 2023
Merged

UI: Bug Fix - Left Nav Bar #6650

merged 1 commit into from
Nov 11, 2023

Conversation

DawoudIO
Copy link
Contributor

@DawoudIO DawoudIO commented Nov 11, 2023

Description

Ensure Toggle Sidebar works again

Screenshots (if appropriate)

Before

image

After
image

How should this be manually tested?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DawoudIO DawoudIO added the bug label Nov 11, 2023
@DawoudIO DawoudIO requested a review from DAcodedBEAT November 11, 2023 05:35
<i class="fa <?= $menuItem->getIcon() ?>"></i>
<span>
<i class="nav-icon fa <?= $menuItem->getIcon() ?>"></i>
<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the change from span-tag to p-tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is what AdminLTE uses, it changed in v3 but we never fixed it

Copy link
Contributor

@DAcodedBEAT DAcodedBEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works, it works 🤷

@DawoudIO DawoudIO merged commit 312bb69 into master Nov 11, 2023
1 check passed
@DawoudIO DawoudIO deleted the ui/fix-leftnav branch November 11, 2023 05:45
@DawoudIO DawoudIO added this to the 5.2.1 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants