Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Issue #53: Added Exit Button, Resolved Row and Column Size, and Implemented score Board #220

Merged
merged 7 commits into from
May 31, 2024

Conversation

Deekshit7483
Copy link
Contributor

@Deekshit7483 Deekshit7483 commented May 23, 2024

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #53

This pull request addresses Issue #53 by implementing the following changes:

  • Added an exit button: Players can now exit the game at any time by clicking the exit button.

  • Resolved row and column size issue: Previously, players could input any number for the rows and columns, leading to
    potential game errors. Now, if a player enters an invalid number (e.g., less than 5 or greater than 30), an error message will
    be displayed, ensuring a smoother user experience.

  • Added source board: Players can now view the score for the game.

    These changes enhance the usability and stability of the game. Tested and verified functionality.


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.



Thank you soo much for contributing to our repository 💗

@Deekshit7483
Copy link
Contributor Author

Deekshit7483 commented May 23, 2024

Added score board

Screenshot from 2024-05-23 13-24-57

Added exit button

Screenshot from 2024-05-23 13-25-12

Resolved Row and Column Size

Screenshot from 2024-05-23 13-25-36

@Deekshit7483 Deekshit7483 changed the title Solved Issue #53: Added Exit Button, Resolved Row and Column Size, and Implemented Source Board Solved Issue #53: Added Exit Button, Resolved Row and Column Size, and Implemented score Board May 23, 2024
@ayush-t02
Copy link
Collaborator

@Deekshit7483

  1. row and column validation has already been done so please remove
  2. conflicts with index.html and style.css, please resolve them

Copy link
Contributor Author

@Deekshit7483 Deekshit7483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayush-t02
Removed row and column validation, and resolved conflicts.

Copy link
Contributor Author

@Deekshit7483 Deekshit7483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict resolved

@ayush-t02 ayush-t02 merged commit 913cad2 into ChromeGaming:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Add Quit Button & Scoreboard Display
2 participants