Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #103- Add the footer #127

Closed
wants to merge 6 commits into from

Conversation

Aditi22Bansal
Copy link

@Aditi22Bansal Aditi22Bansal commented May 14, 2024

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below

The issue was to add a footer to the webpage. By including the appropriate HTML markup for the footer element and applying the necessary CSS styling, I ensured that the footer appeared at the bottom of the page. This addition enhances the overall layout and design of the webpage, providing important information or copyright details to the users.

Fixes #103 <your_issue_number>


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.

## Add your screenshots(Optional) 📸 ![Screenshot 2024-05-15 012917](https://github.com/GameSphere-MultiPlayer/Dot-Box/assets/142652964/4385b9f9-edc7-4cc0-bb52-f0f0f0d935b6)

Thank you soo much for contributing to our repository 💗

@Aditi22Bansal
Copy link
Author

@Durgesh4993
Kindly review the PR

@Aditi22Bansal Aditi22Bansal changed the title Solving issue #103- Add the footer Solved issue #103- Add the footer May 16, 2024
@Aditi22Bansal
Copy link
Author

Aditi22Bansal commented May 17, 2024

@Durgesh4993
Kindly review this PR too
Attaching the screenshot
image

@Aditi22Bansal
Copy link
Author

Aditi22Bansal commented May 21, 2024

@Lovelyfin00
Kindly review this PR also
Thankyou

Copy link
Collaborator

@Lovelyfin00 Lovelyfin00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 100 in the index.html file, remove the comment there. It shows up in the UI

@Lovelyfin00 Lovelyfin00 changed the base branch from main to develop May 21, 2024 07:55
@Lovelyfin00
Copy link
Collaborator

Also update your PR by pulling from develop branch. And I can't start the game while in your PR. You might have unintentionally broke something

@Aditi22Bansal
Copy link
Author

done @Lovelyfin00

@Lovelyfin00
Copy link
Collaborator

And also what you've added here is different from the screenshot you attached in the issue.

@Lovelyfin00
Copy link
Collaborator

I just found out that this has already been assigned to someone else. Give it some days, if the other person doesn't fix the comments by weekend, then you can refactor your PR to what's in the issue design

@Aditi22Bansal
Copy link
Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Want to add the footer !
3 participants