Fix legacy template parameter passing (#355)

* all scalars should be converted to string like for templatecontext of job/stage
ChristopherHX · Jun 15, 2024 · 7a27981 · 7a27981
1 parent 9f3d6a1
commit 7a27981
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 4 deletions.
diff --git a/src/Sdk/AzurePipelines/AzureDevops.cs b/src/Sdk/AzurePipelines/AzureDevops.cs
@@ -706,11 +706,11 @@ public static async Task<MappingToken> ReadTemplate(Runner.Server.Azure.Devops.C
                     var paramname = (kv.Key as StringToken)?.Value;
                     if (cparameters?.TryGetValue(paramname, out var value) == true)
                     {
-                        parametersData[paramname] = value.ToContextData();
+                        parametersData[paramname] = ConvertAllScalarsToString(value).ToContextData();
                     }
                     else
                     {
-                        parametersData[paramname] = kv.Value.ToContextData();
+                        parametersData[paramname] = ConvertAllScalarsToString(kv.Value).ToContextData();
                     }
                 }
             }
@@ -776,7 +776,7 @@ public static async Task<MappingToken> ReadTemplate(Runner.Server.Azure.Devops.C
             templateContext.Errors.Check();
             if(!strictParametersCheck && cparameters != null) {
                 foreach(var param in cparameters) {
-                    parametersData[param.Key] = param.Value.ToContextData();
+                    parametersData[param.Key] = ConvertAllScalarsToString(param.Value).ToContextData();
                 }
             }
 

diff --git a/src/azure-pipelines-vscode-ext/CHANGELOG.md b/src/azure-pipelines-vscode-ext/CHANGELOG.md
@@ -1,3 +1,11 @@
+### v0.0.16
+- fix steps.*.continueOnError / allowed boolean values 
+- make condition stricter
+  - no longer accept `$[ ]` for conditions
+  - check step conditions
+- fix invalid parameter passing to legacy templates using a parameter mapping or omit it
+  - all scalars should be strings like for job/stage templateContext
+
 ### v0.0.15
 - fix variable templates using expressions in it's parameters
 - fix empty dependsOn e.g. empty string is not a missing dependency

diff --git a/src/azure-pipelines-vscode-ext/package.json b/src/azure-pipelines-vscode-ext/package.json
@@ -8,7 +8,7 @@
 		"Programming Languages"
 	],
 	"icon": "pipeline-rocket.png",
-	"version": "0.0.15",
+	"version": "0.0.16",
 	"publisher": "christopherhx",
 	"repository": "https://github.com/ChristopherHX/runner.server",
 	"engines": {

diff --git a/testworkflows/azpipelines/legacy-parameter-passing-test-dotnet-arcade/job.yml b/testworkflows/azpipelines/legacy-parameter-passing-test-dotnet-arcade/job.yml
@@ -0,0 +1,9 @@
+parameters:
+# 1es specific parameters
+  is1ESPipeline: ''
+
+jobs:
+- job:
+  steps:
+  - ${{ if eq(parameters.is1ESPipeline, '') }}:
+    - 'Illegal entry point, is1ESPipeline is not defined. Repository yaml should not directly reference templates in core-templates folder.': error
diff --git a/testworkflows/azpipelines/legacy-parameter-passing-test-dotnet-arcade/pipeline.yml b/testworkflows/azpipelines/legacy-parameter-passing-test-dotnet-arcade/pipeline.yml
@@ -0,0 +1,7 @@
+jobs:
+- template: /job.yml
+  parameters:
+    is1ESPipeline: false
+
+    steps:
+    - bash: exit 0