Skip to content
This repository was archived by the owner on Oct 10, 2024. It is now read-only.

Gatsby 3 #104

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
"@types/youtube": "0.0.38",
"classnames": "^2.2.6",
"date-fns": "^2.14.0",
"gatsby": "^2.21.7",
"gatsby-image": "^2.4.0",
"gatsby-plugin-google-analytics": "^2.3.19",
"gatsby-plugin-netlify": "^2.3.2",
"gatsby": "^3.0.0",
"gatsby-image": "^3.0.0",
"gatsby-plugin-google-analytics": "^3.0.0",
"gatsby-plugin-netlify": "^3.0.0",
"gatsby-plugin-react-svg": "^3.0.0",
"gatsby-plugin-sass": "^2.3.2",
"gatsby-plugin-sass": "^4.0.0",
"js-cookie": "^2.2.1",
"object-hash": "^2.0.3",
"query-string": "^6.12.1",
Expand Down Expand Up @@ -58,19 +58,19 @@
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-react": "^7.19.0",
"eslint-plugin-react-hooks": "^3.0.0",
"gatsby-plugin-catch-links": "^2.3.2",
"gatsby-plugin-manifest": "^2.4.1",
"gatsby-plugin-offline": "^3.2.0",
"gatsby-plugin-react-helmet": "^3.3.0",
"gatsby-plugin-sharp": "^2.6.3",
"gatsby-plugin-catch-links": "^3.0.0",
"gatsby-plugin-manifest": "^3.0.0",
"gatsby-plugin-offline": "^3.0.0",
"gatsby-plugin-react-helmet": "^4.0.0",
"gatsby-plugin-sharp": "^3.0.0",
"gatsby-plugin-typegen": "^2.1.0",
"gatsby-plugin-typescript": "^2.4.0",
"gatsby-source-filesystem": "^2.3.0",
"gatsby-source-local-git": "^1.0.0",
"gatsby-source-sanity": "^5.0.6",
"gatsby-transformer-remark": "^2.8.3",
"gatsby-plugin-typescript": "^3.0.0",
"gatsby-source-filesystem": "^3.0.0",
"gatsby-source-local-git": "^1.3.0",
"gatsby-source-sanity": "^6.0.0",
"gatsby-transformer-remark": "^3.0.0",
"gatsby-transformer-remark-frontmatter": "^0.1.0",
"gatsby-transformer-sharp": "^2.5.0",
"gatsby-transformer-sharp": "^3.0.0",
"identity-obj-proxy": "^3.0.0",
"jest": "^26.0.1",
"patch-package": "^6.2.2",
Expand Down
6 changes: 2 additions & 4 deletions patches/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ See <https://github.com/ds300/patch-package>. Essentially, it lets us modify the
## What changes have you made then?

### `gatsby-plugin-sharp`
The patch file for this has two changes.
1. By default it always adds the original image resolution to the generated `srcSet`. This is confusing and annoying as it basically means it doesn't respect its own `maxWidth` param, and risks us serving a masssive image to the user when we weren't expecting to. So we remove it.
2. We globally make `fluid` query generate a couple of extra sizes, so that the browser is more likely to download only exactly the right sized image.
We globally make `fluid` query generate a couple of extra sizes, so that the browser is more likely to download only exactly the right sized image.


### `react-hook-form`
Bad type def for errors - says it returns string | ReactElement - it should only be string.
https://github.com/react-hook-form/react-hook-form/issues/1713
https://github.com/react-hook-form/react-hook-form/issues/1713
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/node_modules/gatsby-plugin-sharp/index.js b/node_modules/gatsby-plugin-sharp/index.js
index ce52971..0faeec3 100644
index ea4fd6b..b4382a2 100644
--- a/node_modules/gatsby-plugin-sharp/index.js
+++ b/node_modules/gatsby-plugin-sharp/index.js
@@ -519,9 +519,14 @@ async function fluid({
@@ -518,10 +518,17 @@ async function fluid({
]; // use standard breakpoints if no custom breakpoints are specified

if (!options.srcSetBreakpoints || !options.srcSetBreakpoints.length) {
Expand All @@ -18,15 +18,8 @@ index ce52971..0faeec3 100644
+ fluidSizes.push(options[fixedDimension] * 1.6);
+ fluidSizes.push(options[fixedDimension] * 1.8);
fluidSizes.push(options[fixedDimension] * 2);
+
+
} else {
options.srcSetBreakpoints.forEach(breakpoint => {
@@ -542,7 +547,8 @@ async function fluid({
// is available for small images. Also so we can link to
// the original image.

- filteredSizes.push(fixedDimension === `maxWidth` ? width : height); // Queue sizes for processing.
+ // Gatsby adds the original image for some reason. This is bizarre so I'm removing that line.
+ // filteredSizes.push(fixedDimension === `maxWidth` ? width : height); // Queue sizes for processing.

const dimensionAttr = fixedDimension === `maxWidth` ? `width` : `height`;
const otherDimensionAttr = fixedDimension === `maxWidth` ? `height` : `width`; // Sort sizes for prettiness.
if (breakpoint < 1) {
2 changes: 1 addition & 1 deletion src/components/basic-text-page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from "react"

import HeaderUnderlay from "./header-underlay"
import Section from "./section"
import styles from "./basic-text-page.module.scss"
import * as styles from "./basic-text-page.module.scss"

type BasicTextProps = {
html?: string
Expand Down
2 changes: 1 addition & 1 deletion src/components/big-video.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { FC } from "react"
import YouTube from "react-youtube"

import styles from "./big-video.module.scss"
import * as styles from "./big-video.module.scss"

interface BigVideoProps {
youTubeVideoId: string
Expand Down
2 changes: 1 addition & 1 deletion src/components/bio.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { graphql } from "gatsby"
import Img from "./img"
import { sortedWithPriority } from "../utils"

import styles from "./bio.module.scss"
import * as styles from "./bio.module.scss"
import FindOutMoreText from "./find-out-more-text"
import Section from "./section"

Expand Down
2 changes: 1 addition & 1 deletion src/components/christmas/christmas2020.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react"
import { graphql, useStaticQuery } from "gatsby"
import styles from "./christmas2020.module.scss"
import * as styles from "./christmas2020.module.scss"
import { parseISO } from "date-fns"
import Section from "../section"
import PartiallyDisclosedList from "./partially-disclosed-list"
Expand Down
2 changes: 1 addition & 1 deletion src/components/christmas/christmas2021.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react"
import { graphql, useStaticQuery } from "gatsby"
import styles from "./christmas2021.module.scss"
import * as styles from "./christmas2021.module.scss"
import Section from "../section"
import ChristmasTitle from "../../content/christmas2021/christmaswordmark.inline.svg"
import { EventListing, hasSingleEventPassedFilter, SingleEvent } from "./event"
Expand Down
2 changes: 1 addition & 1 deletion src/components/christmas/event.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { format, isAfter, sub } from "date-fns"
import React from "react"
import styles from "./christmas2021.module.scss"
import * as styles from "./christmas2021.module.scss"

export type SingleEvent = {
title: string
Expand Down
2 changes: 1 addition & 1 deletion src/components/cookie-notice.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import classnames from "classnames"
import React from "react"
import { graphql, useStaticQuery, Link } from "gatsby"

import styles from "./cookie-notice.module.scss"
import * as styles from "./cookie-notice.module.scss"
import useConsentCookie from "./hooks/useConsentCookie"

const CookieNotice = () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/covid-notice.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react"
import { graphql, useStaticQuery } from "gatsby"
import Section from "./section"
import styles from "./covid-notice.module.scss"
import * as styles from "./covid-notice.module.scss"

const CovidNotice = () => {
const { covid } = useStaticQuery<GatsbyTypes.CovidQuery>(graphql`
Expand Down
2 changes: 1 addition & 1 deletion src/components/double-image-section.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import classnames from "classnames"
import React, { FC, ReactNode } from "react"

import styles from "./double-image-section.module.scss"
import * as styles from "./double-image-section.module.scss"
import Section from "./section"

type ImagesPosition = "left" | "right"
Expand Down
2 changes: 1 addition & 1 deletion src/components/find-out-more-text.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { FC } from "react"

import styles from "./find-out-more-text.module.scss"
import * as styles from "./find-out-more-text.module.scss"

interface FindOutMoreTextProps {
innerHTML: string
Expand Down
2 changes: 1 addition & 1 deletion src/components/find-out-more.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { FC, HTMLProps } from "react"

import styles from "./find-out-more.module.scss"
import * as styles from "./find-out-more.module.scss"
import Section from "./section"

interface FindOutMoreProps extends HTMLProps<HTMLDivElement> {}
Expand Down
2 changes: 1 addition & 1 deletion src/components/find-us.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { InView } from "react-intersection-observer"
import MapPin from "../assets/icons/mappin.inline.svg"
import Roundel from "../assets/icons/roundel2.inline.svg"

import styles from "./find-us.module.scss"
import * as styles from "./find-us.module.scss"
import Section from "./section"

const LATITUDE = 51.505263
Expand Down
2 changes: 1 addition & 1 deletion src/components/footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useStaticQuery, graphql, Link } from "gatsby"

import CcmLogo from "../content/assets/images/ccm-logo-full.inline.svg"

import styles from "./footer.module.scss"
import * as styles from "./footer.module.scss"
import SocialMediaIcon from "./social-media-icon"

const links: Array<{ path: string; title: string }> = [
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/field.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react"

import styles from "./field.module.scss"
import * as styles from "./field.module.scss"
import classNames from "classnames"

interface Props {
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/fields/basic-text-field.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Field from "../field"
import React from "react"
import classNames from "classnames"
import formStyles from "../form.module.scss"
import * as formStyles from "../form.module.scss"
import { ReactHookFormWiring, CommonField } from "../form-config.types"
import { prependRequired } from "../form"
import { shouldShowField } from "../conditional-visibility"
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/fields/checkbox-field.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ReactHookFormWiring, CommonField } from "../form-config.types"
import Field from "../field"
import React from "react"
import classNames from "classnames"
import formStyles from "../form.module.scss"
import * as formStyles from "../form.module.scss"
import { prependRequired } from "../form"
import { shouldShowField, VisibilityCondition } from "../conditional-visibility"

Expand Down
2 changes: 1 addition & 1 deletion src/components/form/fields/date-field.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Field from "../field"
import React from "react"
import classNames from "classnames"
import formStyles from "../form.module.scss"
import * as formStyles from "../form.module.scss"
import { ReactHookFormWiring, CommonField } from "../form-config.types"
import { prependRequired } from "../form"
import { Controller } from "react-hook-form"
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/fields/drop-down-field.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ReactHookFormWiring, CommonField } from "../form-config.types"
import { prependRequired } from "../form"
import Field from "../field"
import React from "react"
import formStyles from "../form.module.scss"
import * as formStyles from "../form.module.scss"
import { shouldShowField } from "../conditional-visibility"

type DropDownChoice = {
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/fields/form-section-start.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react"
import { shouldShowField, VisibilityCondition } from "../conditional-visibility"
import { ReactHookFormWiring } from "../form-config.types"
import formStyles from "../form.module.scss"
import * as formStyles from "../form.module.scss"

type Props = {
showWhen?: VisibilityCondition
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/fields/number-field.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Field from "../field"
import React from "react"
import classNames from "classnames"
import formStyles from "../form.module.scss"
import * as formStyles from "../form.module.scss"
import { ReactHookFormWiring, CommonField } from "../form-config.types"
import { prependRequired } from "../form"
import { shouldShowField } from "../conditional-visibility"
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/fields/radio-button-field.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ReactHookFormWiring, CommonField } from "../form-config.types"
import Field from "../field"
import React from "react"
import classNames from "classnames"
import formStyles from "../form.module.scss"
import * as formStyles from "../form.module.scss"
import { prependRequired } from "../form"
import { shouldShowField } from "../conditional-visibility"

Expand Down
2 changes: 1 addition & 1 deletion src/components/form/form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React from "react"
import Field from "./field"
import { useForm } from "react-hook-form"

import formStyles from "./form.module.scss"
import * as formStyles from "./form.module.scss"
import classNames from "classnames"
import { ValidationOptions } from "react-hook-form"
import Section from "../section"
Expand Down
2 changes: 1 addition & 1 deletion src/components/gospelgenerationstrust/alum.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { FC } from "react"

import styles from "./alum.module.scss"
import * as styles from "./alum.module.scss"
import Img, { FluidObject } from "../img"

type AlumProps = {
Expand Down
2 changes: 1 addition & 1 deletion src/components/gospelgenerationstrust/footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useStaticQuery, graphql, Link } from "gatsby"

import GospelGenerationsTrustLogoFull from "../../content/assets/images/gospelgenerationstrust-logo.inline.svg"

import styles from "../footer.module.scss"
import * as styles from "../footer.module.scss"

const links: Array<{ path: string; title: string }> = [
{ path: "/gospelgenerationstrust/stories", title: "Stories" },
Expand Down
2 changes: 1 addition & 1 deletion src/components/gospelgenerationstrust/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import GospelGenerationsTrustLogoFull from "../../content/assets/images/gospelge
import CloseMenuButton from "../../content/assets/images/close-menu-button.inline.svg"
import Hamburger from "../../content/assets/images/hamburger.inline.svg"

import styles from "../header.module.scss"
import * as styles from "../header.module.scss"

const MAX_WIDTH_MOBILE_HEADER = 968

Expand Down
2 changes: 1 addition & 1 deletion src/components/header-underlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { FC, HTMLProps } from "react"

import Section, { colorScheme } from "./section"

import styles from "./header-underlay.module.scss"
import * as styles from "./header-underlay.module.scss"
import classNames from "classnames"

interface HeaderUnderlayProps extends HTMLProps<HTMLDivElement> {
Expand Down
2 changes: 1 addition & 1 deletion src/components/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import CcmLogoFull from "../content/assets/images/ccm-logo-full.inline.svg"
import CloseMenuButton from "../content/assets/images/close-menu-button.inline.svg"
import Hamburger from "../content/assets/images/hamburger.inline.svg"

import styles from "./header.module.scss"
import * as styles from "./header.module.scss"

const MAX_WIDTH_MOBILE_HEADER = 968

Expand Down
2 changes: 1 addition & 1 deletion src/components/hero.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react"

import Img, { FluidObject } from "./img"
import styles from "./hero.module.scss"
import * as styles from "./hero.module.scss"
import Section from "./section"

interface HeroProps {
Expand Down
2 changes: 1 addition & 1 deletion src/components/hopeinthedarkness.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react"
import { graphql, useStaticQuery } from "gatsby"
import styles from "./hopeinthedarkness.module.scss"
import * as styles from "./hopeinthedarkness.module.scss"
import Section from "./section"

const HopeInTheDarkness = () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/important-notice.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import classNames from "classnames"
import React, { FC } from "react"

import styles from "./important-notice.module.scss"
import * as styles from "./important-notice.module.scss"
import Section from "./section"
import SectionText from "./section-text"

Expand Down
2 changes: 1 addition & 1 deletion src/components/large-navigation-buttons.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import classnames from "classnames"
import React, { FC, ElementType, Fragment } from "react"

import styles from "./large-navigation-buttons.module.scss"
import * as styles from "./large-navigation-buttons.module.scss"
import { Link } from "gatsby"

interface ButtonConfig {
Expand Down
2 changes: 1 addition & 1 deletion src/components/london-living-promo.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react"
import { graphql, useStaticQuery } from "gatsby"
import styles from "./london-living-promo.module.scss"
import * as styles from "./london-living-promo.module.scss"
import LondonLivingLogo from "../content/londonliving/LL_logo.inline.svg"
import Section from "./section"

Expand Down
2 changes: 1 addition & 1 deletion src/components/missionpartner.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { FC } from "react"

import styles from "./missionpartner.module.scss"
import * as styles from "./missionpartner.module.scss"
import Img, { FluidObject } from "./img"
import classNames from "classnames"

Expand Down
2 changes: 1 addition & 1 deletion src/components/post-lockdown-notice.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react"
import { graphql, useStaticQuery } from "gatsby"
import Section from "./section"
import styles from "./post-lockdown-notice.module.scss"
import * as styles from "./post-lockdown-notice.module.scss"

const PostLockDownNotice = () => {
const { postLockDown } = useStaticQuery<
Expand Down
2 changes: 1 addition & 1 deletion src/components/rootsofjazzpromo.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react"
import { graphql, useStaticQuery } from "gatsby"
import styles from "./rootsofjazz.module.scss"
import * as styles from "./rootsofjazz.module.scss"
import Section from "./section"

const RootsOfJazzPromo = () => {
Expand Down
Loading