Skip to content

Commit

Permalink
fix: Android CodePush deploymentKey
Browse files Browse the repository at this point in the history
  • Loading branch information
dariodumlijan committed Feb 4, 2024
1 parent 5da0e47 commit b829a58
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 15 deletions.
2 changes: 2 additions & 0 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,13 @@ android {
buildTypes {
debug {
signingConfig signingConfigs.debug
resValue "string", "CodePushDeploymentKey", '4ijAnhf96jc8n0bXMofRN3ACQw_KxrG_TM8C8'
}
release {
signingConfig signingConfigs.release
minifyEnabled enableProguardInReleaseBuilds
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
resValue "string", "CodePushDeploymentKey", '4ijAnhf96jc8n0bXMofRN3ACQw_KxrG_TM8C8'
}
}
}
Expand Down
1 change: 0 additions & 1 deletion android/app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<resources>
<string name="app_name">Negative Harmony</string>
<string moduleConfig="true" name="CodePushDeploymentKey">_E6pPExPbuekfs8--1P1KXx0_9PCdp9lfNFHw</string>
</resources>
1 change: 0 additions & 1 deletion app/components/Body.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ function Body() {
const [loadingAnimationDone, setLoadingAnimationDone] = useState(false);
const initLoad = useRef(true);
const timeoutRef = useRef<any>();
// const announcementSeen = get(cms, 'timestamps.local.announcement', 0) < get(cms, 'timestamps.announcement', 0);

useEffect(() => {
if (initLoad.current) {
Expand Down
5 changes: 3 additions & 2 deletions app/components/screens/Info.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ function Info() {
const screenOpacity = useRef(new Animated.Value(0)).current;

const handleDeveloperModeToggle = () => {
if (secretDeviceIdTap === 7) {
const tapCount = secretDeviceIdTap + 1;
if (tapCount === 7) {
dispatch(actions.toggleDeveloperMode(true));
teleport(
<Alert clearDelayMS={secondsToMilliseconds(5)}>
Expand All @@ -32,7 +33,7 @@ function Info() {
return;
}

setSecretDeviceIdTap(secretDeviceIdTap + 1);
setSecretDeviceIdTap(tapCount);
};

useEffect(() => {
Expand Down
11 changes: 1 addition & 10 deletions app/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,5 @@
"paragraph_2": "The negative chord names may not always be exactly right because of the way the chord naming system works.\n\nIn practise the chord name comes from the tonic/root note followed by the structure/pattern (major, minor, suspended...) this rule is broken when looking at negative chords where the tonic/root is actually the last note played going from left to right on the piano.\n\nBecause of this, the app looks if the negative chord pattern has a match when mirrored and compared to the regular one. If so it determines the chord name by taking the 'negative' tonic/root note and displaying the chord name.\n\nThough the chord name may vary depending on what you consider to be the tonic/root note the notes displayed in the negative chords are always correct.",
"paragraph_3": "If you find any bugs, incorrect representations of the notes or chords, please contact us at:\n",
"email": "[email protected]"
},
"announcement": {
"title": "Attention!",
"cta": "Okay"
},
"error": {
"title": "Attention!",
"text": "The new version of Negative Harmony requires internet to download all of the latest features.\n\nPlease make sure you are connected and try again.\n\n*You only need internet to download the latest features once afterwards, you can use the app offline if you wish to do so.",
"cta": "Try Again"
}
}
}
1 change: 0 additions & 1 deletion app/tokens/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export const codepush = {
};

export const localStorageKeys = {
announcementTimestamp: 'announcementTimestamp',
reviewTimestamp: 'reviewTimestamp',
rewardedAt: 'rewardedAt',
};

0 comments on commit b829a58

Please sign in to comment.