Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python 3.13 #1709

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Update to python 3.13 #1709

merged 5 commits into from
Feb 6, 2025

Conversation

rcmerlo
Copy link
Contributor

@rcmerlo rcmerlo commented Jan 17, 2025

  • Tests for the changes have been added
  • Related documentation has been added / updated
  • For new features, QA automation engineers have been tagged
  • OSS packages added to MindLogger open source credit page

📝 Description

This PR updates to python 3.13 latest version, changes also include removing some deprecated code

  • change datetime.datetime.utcnow() to datetime.datetime.now(datetime.UTC), now() frunction returns timezone info in date object, but database code do not accepts timezone in date columns, so to have same behavior of utnow method, we remove timezone info from date object calling .replace(tzinfo=None)
  • change datetime.datetime.utcfromtimestamp() to datetime.datetime.fromtimstamp(tz=datetime.UTC), it have same behavior as now(datetime.UTC), so also need to remove timezone info in some cases
  • Fix others deprecated warnings found

🪤 Peer Testing

pipenv --rm  (to remove old virtualenv)
 
Install python 3.13 using pyenv or brew 

pipenv install --dev         
pipenv sync --dev

Copy link

github-actions bot commented Jan 17, 2025

➡️ Preview environment failed to be destroyed

Copy link

❌ E2E tests failed

@rcmerlo rcmerlo requested review from aweiland and ChaconC and removed request for aweiland February 3, 2025 13:10
@rcmerlo rcmerlo marked this pull request as ready for review February 3, 2025 13:10
@farmerpaul farmerpaul removed their request for review February 3, 2025 22:00
Copy link
Contributor

@ChaconC ChaconC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, and nice job cleaning up the strings all over the place.

README.md Outdated Show resolved Hide resolved
Changed the Python version link from 3.13.1 to 3.13.2 for accuracy in the technologies section of the README file.
@rcmerlo rcmerlo merged commit 206d177 into develop Feb 6, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants