Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the openssl feature to the chia_rs wheel #853

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 8, 2025

and enable it for non-windows builds.

I encountered this issue: https://stackoverflow.com/questions/70464585/error-when-installing-openssl-3-0-1-cant-locate-ipc-cmd-pm-in-inc
The new openssl build step requires a new perl package which needed to be installed on the docker image.

It appears the --features switch to maturin does not add features to what it find in pyproject.toml, but replaces them. That's why I had to also include pyo3/extension-module as a feature on the command line.

Copy link

coveralls-official bot commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12675835638

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.93%

Totals Coverage Status
Change from base Build 12659770161: 0.0%
Covered Lines: 13360
Relevant Lines: 15918

💛 - Coveralls

@arvidn arvidn marked this pull request as draft January 8, 2025 15:47
@arvidn arvidn force-pushed the enable-openssl branch 2 times, most recently from 9bee918 to 8d86bd6 Compare January 8, 2025 16:52
@arvidn arvidn requested a review from Rigidity January 8, 2025 17:50
@arvidn arvidn marked this pull request as ready for review January 8, 2025 17:50
@arvidn arvidn merged commit b422719 into main Jan 8, 2025
52 checks passed
@arvidn arvidn deleted the enable-openssl branch January 8, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants