Pin earcut version #12412
Open
Pin earcut version #12412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
|
Thanks for looking into this @jjspace! I've asked @ArgentumHHH for a Sandcastle example so we can verify this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Version
3.0.0ofearcutdropped support for CommonJS however CesiumJS still supports using it as a CommonJS module. This PR pins the version at2.2.4for now for compatibility.Opened #12411 to track updating this in the future
This was the reported cause of #12294
Issue number and link
Fixes #12294
Testing plan
I'm not entirely sure how to test this with a polygon geometry that has holes @ggetz is there an easy way to make that?
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change