Feat: Card & Text & NavigationHeader 구현 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Inoansta
approved these changes
Jan 30, 2025
Comment on lines
+13
to
+17
| import { | ||
| BottomNavigationLayout, | ||
| PageLayout, | ||
| ProtectedLayout, | ||
| } from '@/shared/ui'; |
Comment on lines
+1
to
+4
| export { default as NavigationHeader } from './NavigationHeader'; | ||
| export { default as PrimaryChips } from './Chips'; | ||
| export { default as Button } from './Buttons'; | ||
| export { default as RouteMove } from './RouteMove'; |
There was a problem hiding this comment.
이렇게 index에 한데 모아서 export 하는 이유가 뭘까요?
Comment on lines
+22
to
+31
| export const useMoveLocation = (location: RouteInfo['location']) => { | ||
| const navigate = useNavigate(); | ||
|
|
||
| const handleMoveLocation = useCallback(() => { | ||
| if (location === 'back') { | ||
| navigate(-1); | ||
| } else { | ||
| navigate(location); | ||
| } | ||
| }, [navigate, location]); |
There was a problem hiding this comment.
외부 라이브러리로 부터의 결합성을 낮추는 이런 방식이 있군요!
Comment on lines
+1
to
+16
| import clsx from 'clsx'; | ||
|
|
||
| interface TextProps { | ||
| as: keyof typeof style; | ||
| title: string; | ||
| className?: string; | ||
| } | ||
|
|
||
| const style = { | ||
| title: 'text-black font-extrabold text-[15px] not-italic', | ||
| description: 'text-gray font-medium text-[13px] not-italic', | ||
| } as const; | ||
|
|
||
| export default function Text({ as, title, className }: TextProps) { | ||
| return <p className={clsx(style[as], className)}>{title}</p>; | ||
| } |
There was a problem hiding this comment.
Text 컴포넌트는 용도가 어떻게 될까요? 스크린샷이 있을까요?
| return <div className={clsx(`flex-1`, className)}>{children}</div>; | ||
| } | ||
|
|
||
| const Card = Object.assign(Root, { Header, Content, Bottom }); |
There was a problem hiding this comment.
이거 배워갑니다. 오픈 소스 라이브러리에서만 보던건데 너무 좋은데요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
2025-01-29.12.58.21.mov
pr 포인트나 궁금한 점을 작성해 주세요
연관된 issue: #undefined