feat: Nav Header 구현 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import HeaderLeft from './items/HeaderLeft'; | ||
|
|
||
| import Close from '@/assets/svg/LargeClose.svg?react'; |
There was a problem hiding this comment.
이렇게 정의하면 lint 에러가 나오지 않나요??
There was a problem hiding this comment.
hook과 컴포넌트와 svg를 일부러 구분해놓았는데 다 붙이는게 나을까요?
Comment on lines
+16
to
+21
| const params = [goBack, title, spark].filter((param) => { | ||
| return param !== undefined; | ||
| }); | ||
| if (params.length > 1) { | ||
| throw new Error('goBack, title, spark 중 하나만 입력해야 합니다.'); | ||
| } |
There was a problem hiding this comment.
의도한걸 파악하기 어려워요!
무슨 의도로 작성하신건가요??
There was a problem hiding this comment.
commnet에 있는것처럼 Param에서 goback, title, spark는 셋중 각각 하나만 입력이 가능합니다!
Comment on lines
+16
to
+36
| if (goBack) { | ||
| return ( | ||
| <ArrowLeftThick | ||
| className={'flex-1 mr-[20px]'} | ||
| onClick={() => navigate(-1)} | ||
| /> | ||
| ); | ||
| } else if (spark) { | ||
| return ( | ||
| <div className={'flex flex-row flex-1 items-center'}> | ||
| <SparkSymbol /> | ||
| <SparkText /> | ||
| </div> | ||
| ); | ||
| } else if (title && title.length > 0) { | ||
| return ( | ||
| <> | ||
| <span className={'flex-1 text-title4-eb'}>{title}</span> | ||
| </> | ||
| ); | ||
| } |
There was a problem hiding this comment.
명령형 프로그래밍이랑 선언형 프로그램 공부하시면 좋을것 같아요!
이 부분은 제가 한번 작성해보겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
pr 포인트나 궁금한 점을 작성해 주세요
연관된 issue: #undefined