Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 사용자 정보기입 페이지 구현 #10
feat: 사용자 정보기입 페이지 구현 #10
Changes from 14 commits
b82c26e
0e92c89
0884eef
2e81490
0b528bf
a885d72
ae8f635
7008a2c
912ecc8
8b47f5f
9679472
7178a1c
00c4a53
f4fdb1a
a6a89bc
7164371
cd07a0d
d083a10
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RefObject라고 정의하신 이유가 궁금합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DOM에 접근해야했고 readonly로 충분하기 떄문에 RefObject를 썼습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컴포넌트 안에 또 컴포넌트로 정의한 이유가 있으신가요?
이렇게 정의하면 리렌더링에 대해서 대응할수 없다는 이슈가 있어서 안티패턴이라고 알고 있어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
유용한 정보 감사합니다! userInformation에서 쓰이는 상태가 많아서 컴포넌트 안에서 정의했습니다
분리하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 로직은 분기처리가 많이 되어있는거 같아요.
만약에 steps가 더 늘어나면 또 분기처리를 해줘야할것 같은데 이 부분에 대해서 한번 더 고민해봤으면 좋겠어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 동의합니다! 두고두고 생각해봐야 할 것 같습니다
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이벤트 정의 함수가 길어지면 가독성 측면에 안좋아요!
따로 빼서 정의하면 좋을것 같아요
This file was deleted.