Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused/commented code #2488

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Clean up unused/commented code #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/preprints/-components/preprint-doi/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { inject as service } from '@ember/service';
import { action } from '@ember/object';
import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
import Intl from 'ember-intl/services/intl';

import PreprintModel, { VersionStatusSimpleLabelKey } from 'ember-osf-web/models/preprint';
import PreprintProviderModel from 'ember-osf-web/models/preprint-provider';
Expand All @@ -14,8 +12,6 @@ interface InputArgs {
}

export default class PreprintAbstract extends Component<InputArgs> {
@service intl!: Intl;

provider = this.args.provider;
documentType = this.provider.documentType.singularCapitalized;

Expand Down
2 changes: 0 additions & 2 deletions app/preprints/-components/submit/preprint-state-machine/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import captureException, { getApiErrorMessage } from 'ember-osf-web/utils/captur
import { Permission } from 'ember-osf-web/models/osf-model';
import { ReviewsState } from 'ember-osf-web/models/provider';
import InstitutionModel from 'ember-osf-web/models/institution';
import CurrentUserService from 'ember-osf-web/services/current-user';
import { ReviewActionTrigger } from 'ember-osf-web/models/review-action';

export enum PreprintStatusTypeEnum {
Expand Down Expand Up @@ -46,7 +45,6 @@ export default class PreprintStateMachine extends Component<StateMachineArgs>{
@service router!: RouterService;
@service intl!: Intl;
@service toast!: Toast;
@service currentUser!: CurrentUserService;

titleAndAbstractValidation = false;
fileValidation = false;
Expand Down
20 changes: 0 additions & 20 deletions app/preprints/new-version/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import Store from '@ember-data/store';
import Route from '@ember/routing/route';
import RouterService from '@ember/routing/router-service';
import { inject as service } from '@ember/service';
import Toast from 'ember-toastr/services/toast';
import Intl from 'ember-intl/services/intl';

import Theme from 'ember-osf-web/services/theme';
import MetaTags, { HeadTagDef } from 'ember-osf-web/services/meta-tags';
Expand All @@ -14,9 +12,6 @@ export default class PreprintNewVersionRoute extends Route {
@service theme!: Theme;
@service router!: RouterService;
@service metaTags!: MetaTags;
@service toast!: Toast;
@service intl!: Intl;


headTags?: HeadTagDef[];

Expand All @@ -36,21 +31,6 @@ export default class PreprintNewVersionRoute extends Route {

const preprint: PreprintModel = await this.store.findRecord('preprint', args.guid);

// TODO: Re-evaluate if re-route logic is necessary
// if (!preprint.canCreateNewVersion) {
// let message = this.intl.t('preprints.submit.new-version.redirect.latest-published',
// { preprintWord: provider.documentType.singular });
// if (!preprint.currentUserIsAdmin) {
// message = this.intl.t('preprints.submit.new-version.redirect.permission',
// { preprintWord: provider.documentType.singular });
// }

// const title = this.intl.t('preprints.submit.new-version.redirect.title');
// this.toast.info(message, title);
// this.router.transitionTo('preprints.detail', args.provider_id, args.guid);
// return null;
// }

return {
provider,
preprint,
Expand Down
Loading