Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import of sql from various file types in the #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nalipaz
Copy link

@nalipaz nalipaz commented Apr 8, 2016

/docker-entrypoint-initdb.d/ directory

As described in #53 I am not completely sure on how well this works since I have not had a chance to test it yet, but in theory it should work fine.

@jperrin
Copy link
Collaborator

jperrin commented Apr 19, 2016

@dustymabe, @goern does this make sense to you? Would this be beneficial to openshift?

@goern
Copy link
Contributor

goern commented Apr 19, 2016

looks like this is a good way to import data from a mysql_dump, seems like we can base a migration/upgrade story around this behavior.

#needs_doc ;)

LGTM

@jperrin
Copy link
Collaborator

jperrin commented Apr 19, 2016

@nalipaz I think @goern brings up a good point. Could you add a bit of doc for using this in the readme? Once we have that I can merge it in.

@@ -19,6 +19,9 @@ if [ "$1" = 'mysqld_safe' ]; then
mysql_install_db --datadir="$DATADIR"
echo 'Finished mysql_install_db'

# Setup a default mysql connection command.
mysql=( mysql --protocol=socket -uroot )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you are using an array here and not a string so you don't have to manage spaces in the command? I typically do this with a string, but an open to this way as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this further just a day or two ago and imports aren't happening I was not able to get it working and I may be barking up the wrong tree with my approach. I was basing this approach on the mariadb docker-entrypoint.sh as seen here: https://github.com/docker-library/mysql/blob/5b1a6a2b50efceac44579df0936facfee654a805/5.7/docker-entrypoint.sh

Perhaps someone here has more insight on how this should work.

@nalipaz
Copy link
Author

nalipaz commented Apr 19, 2016

I have added a commit for some documentation in the README.md. Let me know if that looks alright. It is pretty verbatim from the mysql docker README.md

@goern
Copy link
Contributor

goern commented Apr 19, 2016

I just see two commits in this PR @nalipaz

@nalipaz
Copy link
Author

nalipaz commented Apr 19, 2016

@goern oops, there it is.

@goern goern removed the needs_doc label Apr 19, 2016
@goern
Copy link
Contributor

goern commented Apr 19, 2016

LGTM

@goern
Copy link
Contributor

goern commented Apr 19, 2016

This issue is blocking fedora-cloud/Fedora-Dockerfiles#203

@jperrin
Copy link
Collaborator

jperrin commented May 3, 2016

@goern who's working on syncing the two sets of dockerfiles to remove the block, or is that you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants