-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import of sql from various file types in the #54
base: master
Are you sure you want to change the base?
Add import of sql from various file types in the #54
Conversation
/docker-entrypoint-initdb.d/ directory
@dustymabe, @goern does this make sense to you? Would this be beneficial to openshift? |
looks like this is a good way to import data from a mysql_dump, seems like we can base a migration/upgrade story around this behavior. #needs_doc ;) LGTM |
@@ -19,6 +19,9 @@ if [ "$1" = 'mysqld_safe' ]; then | |||
mysql_install_db --datadir="$DATADIR" | |||
echo 'Finished mysql_install_db' | |||
|
|||
# Setup a default mysql connection command. | |||
mysql=( mysql --protocol=socket -uroot ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you are using an array here and not a string so you don't have to manage spaces in the command? I typically do this with a string, but an open to this way as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this further just a day or two ago and imports aren't happening I was not able to get it working and I may be barking up the wrong tree with my approach. I was basing this approach on the mariadb docker-entrypoint.sh as seen here: https://github.com/docker-library/mysql/blob/5b1a6a2b50efceac44579df0936facfee654a805/5.7/docker-entrypoint.sh
Perhaps someone here has more insight on how this should work.
I have added a commit for some documentation in the README.md. Let me know if that looks alright. It is pretty verbatim from the mysql docker README.md |
I just see two commits in this PR @nalipaz |
@goern oops, there it is. |
LGTM |
This issue is blocking fedora-cloud/Fedora-Dockerfiles#203 |
@goern who's working on syncing the two sets of dockerfiles to remove the block, or is that you? |
/docker-entrypoint-initdb.d/ directory
As described in #53 I am not completely sure on how well this works since I have not had a chance to test it yet, but in theory it should work fine.