Fix #849 by caching previous states #880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsgrefer
requested changes
Jan 14, 2017
| /** | ||
| * Created by Kai on 2016/6/3. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Please remove the empty line here
| import com.secupwn.aimsicd.utils.Device; | ||
|
|
||
| /** | ||
| * Created by Kai on 2016/6/3. |
There was a problem hiding this comment.
please use the @author javadoc-tag here
| private String networkRoaming; | ||
| private int phoneId; | ||
|
|
||
| public String getLocationAreaCode() { |
There was a problem hiding this comment.
Please use lombok's @Getter for all the getters
|
@kaichunlin Do you plan to finish this PR? Or should it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agreements
Overview
When switching to another fragment and back to
DeviceFragment, all texts will be animated since the fragment is a completely new fragment with no memory of the states of its previous instance.The modifications is to store the last displayed state of the
DeviceFragmentsuch that when a new instance is created only the diff of the new states will be animated/highlighted.Classification
References
Screenshots