Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update number formatting #1999

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Conversation

ajtribick
Copy link
Collaborator

  • Use fmt as the base implementation
  • Support Indian-style digit grouping (e.g 12,34,56,789)
  • Obtain separators from wchar_t facets
  • Avoid doing floating point math to determine significant figures

Re-generated the translations as this results in a change to the mass display strings.

@ajtribick ajtribick force-pushed the numformat branch 3 times, most recently from 8f8c9e9 to d036588 Compare December 3, 2023 20:32
- Use fmt as the base implementation
- Support Indian-style digit grouping
- Obtain separators from wchar_t facets
- Avoid doing floating point math to determine significant figures
Copy link

sonarqubecloud bot commented Dec 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ajtribick ajtribick merged commit f11a8c5 into CelestiaProject:master Dec 3, 2023
12 checks passed
@ajtribick ajtribick deleted the numformat branch December 3, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants