-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macos wheel building and coverage reporting #514
Conversation
This is almost done. There is still an issue with the combined coverage. The statistics report it as 40% coverage when combining the pytest-split files, but when I run all the tests locally without pytest-split I get >90% which is the correct metric. |
I'm trying to understand why does the coverage test fails on Cedergrouphub but not in your repo @lbluque |
In the Cedergrouphub test, the artifacts for coverage were not able to be downloaded. This is the step right before running coverage |
Ah after merging the tests are passing! |
Summary
Fixes #511 macosx wheels building successfully
[WIP] Fixes reporting coverage after addition of pytest-split for faster tests #486
Checklist
Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: