Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos wheel building and coverage reporting #514

Merged
merged 23 commits into from
Feb 8, 2025

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Feb 5, 2025

Summary

Fixes #511 macosx wheels building successfully
[WIP] Fixes reporting coverage after addition of pytest-split for faster tests #486

Checklist

  • All existing tests pass.
  • Tests have been added for any new features/fixes.
  • Docstrings have been added in the Google docstring format.

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@lbluque
Copy link
Collaborator Author

lbluque commented Feb 7, 2025

This is almost done.

There is still an issue with the combined coverage. The statistics report it as 40% coverage when combining the pytest-split files, but when I run all the tests locally without pytest-split I get >90% which is the correct metric.

@lbluque lbluque requested a review from kamronald February 7, 2025 15:29
@lbluque lbluque added testing Unit tests for implemented features github_actions Pull requests that update GitHub Actions code labels Feb 7, 2025
@lbluque lbluque self-assigned this Feb 7, 2025
@kamronald
Copy link
Collaborator

kamronald commented Feb 7, 2025

I'm trying to understand why does the coverage test fails on Cedergrouphub but not in your repo @lbluque

@kamronald
Copy link
Collaborator

In the Cedergrouphub test, the artifacts for coverage were not able to be downloaded. This is the step right before running coverage

@kamronald kamronald merged commit 9b05c9d into CederGroupHub:main Feb 8, 2025
19 of 20 checks passed
@kamronald
Copy link
Collaborator

Ah after merging the tests are passing!

@lbluque lbluque changed the title [WIP] Fix macos wheel building and coverage reporting Fix macos wheel building and coverage reporting Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code testing Unit tests for implemented features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Errors in Pypi release workflow
2 participants