Update evaluation of sampling efficiency in SampleContainer #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize the sampling efficiency by number of samples saved, instead of the total number of MC iterations.
Summary
Major changes:
Changed the definition of sampling efficiency to be "# acceptances" / "# samples considered". For MC runs with sample thinning > 1, this becomes only an estimate for the true sampling efficiency, as we do not know the sampling efficiency of the discarded samples. However this estimate should be more accurate than the previous definition of sampling efficiency: "# acceptances" / "# total number of MC iterations"
Todos
If this is work in progress, what else needs to be done?
Checklist
Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: