Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Fix unordered SolutionArray append #1840

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jan 21, 2025

If applicable, fill in the issue number this pull request is fixing

Closes #1838

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl marked this pull request as ready for review January 21, 2025 15:03
@ischoegl ischoegl requested a review from a team January 21, 2025 15:03
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (2e0d8ac) to head (6ea5110).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1840   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         382      382           
  Lines       53411    53411           
  Branches     9026     9026           
=======================================
  Hits        39747    39747           
  Misses      10617    10617           
  Partials     3047     3047           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. This looks good to me.

@speth speth merged commit e647b9d into Cantera:main Jan 22, 2025
44 of 49 checks passed
@ischoegl ischoegl deleted the fix-1838 branch January 22, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SolutionArray.append: Keyword arguments parsed incorrectly
2 participants