-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Species Sensitivity Analysis for 1D Flames #1830
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marina8888 ... thank you for the PR! Apart from minor formatting comments, we usually request unit tests for our pytest
test suite for new additions. Likewise, it would be great if you could add an example that illustrates species sensitivity analysis (something based on what you have posted in your PR description would be perfectly adequate). For some pointers, please refer to Cantera's Contributing Guidelines. Beyond that, we'd be happy to provide assistance for this PR in case you should have any questions!
…into feature/one-dim-sens
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
+ Coverage 74.41% 74.42% +0.01%
==========================================
Files 382 382
Lines 53411 53423 +12
Branches 9026 9026
==========================================
+ Hits 39747 39762 +15
+ Misses 10617 10615 -2
+ Partials 3047 3046 -1 ☔ View full report in Codecov by Sentry. |
This PR is for the addition of a 1D species sensitivity analysis in the Python interface. Closes the long overdue Enhancement 71.
I have another version considering distance as input, but this requires some additional logic and for error handling for distances outside of the domain.
Tested code on ImpingingJet flame and FreeFlame to confirm the behaviour is as expected. Please see an example code for usage.