Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): changed featureIcon to data URL at creation #2738

Conversation

DamonU2
Copy link
Member

@DamonU2 DamonU2 commented Feb 6, 2025

Closes #2719

Description

featureIcon changed to string from HTML canvas element. Now changed to a data URL before assignment. Feature highlight for points now uses a set value for the size of the highlight circle.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/outlier-ESRI-maxRecordCount.html Feb. 6 at 2:20 Eastern

Best way to see the speed increase in the data table is to load both tables and then switch between them - no query, you just see how long to render. Tried the same for loading the map - keeping layer info in cache and reloading.

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@DamonU2 DamonU2 requested a review from jolevesq February 6, 2025 19:21
@DamonU2 DamonU2 self-assigned this Feb 6, 2025
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq merged commit 1a57df1 into Canadian-Geospatial-Platform:develop Feb 6, 2025
6 checks passed
Copy link
Member

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@DamonU2 DamonU2 deleted the 2720-ESRI-dynamic-export-query branch February 7, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] data table: canvas element conversion happening for every feature
3 participants