feat(performance): changed featureIcon to data URL at creation #2738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2719
Description
featureIcon changed to string from HTML canvas element. Now changed to a data URL before assignment. Feature highlight for points now uses a set value for the size of the highlight circle.
Type of change
How Has This Been Tested?
https://damonu2.github.io/geoview/outlier-ESRI-maxRecordCount.html Feb. 6 at 2:20 Eastern
Best way to see the speed increase in the data table is to load both tables and then switch between them - no query, you just see how long to render. Tried the same for loading the map - keeping layer info in cache and reloading.
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)