-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2673 ESRI Renderer to GeoView Style Demo Page #2731
base: develop
Are you sure you want to change the base?
2673 ESRI Renderer to GeoView Style Demo Page #2731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2 and @MatthewMuehlhauserNRCan)
packages/geoview-core/public/templates/demos/demo-esri-renderer.html
line 83 at r1 (raw file):
} .line-numbers span::before {
We have a style.css file in public css to handle demo pages style. Is it copy paste from another page were we did not use the style css?
packages/geoview-core/public/templates/demos/demo-esri-renderer.html
line 224 at r1 (raw file):
} }
Trailing white spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @DamonU2 and @MatthewMuehlhauserNRCan)
packages/geoview-core/public/templates/demos/demo-esri-renderer.html
line 140 at r1 (raw file):
If a Feature Service URL is provided, then a layer config with the style included will be generated. <br> Example: <i>https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/earthquakes_en/MapServer/0</i>
Can you add few test url (simple, unique value, class break.) This url as unique value but return simple https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/historical_flood_event_en/MapServer/0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @DamonU2 and @jolevesq)
packages/geoview-core/public/templates/demos/demo-esri-renderer.html
line 83 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
We have a style.css file in public css to handle demo pages style. Is it copy paste from another page were we did not use the style css?
I took a copy of the Config Sandbox. It looks like it links to the style.css, but still has all the style in the style tag. That said, the "line-number" class styles are missing from the style.css. Should I add them?
packages/geoview-core/public/templates/demos/demo-esri-renderer.html
line 140 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Can you add few test url (simple, unique value, class break.) This url as unique value but return simple https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/historical_flood_event_en/MapServer/0
Done
packages/geoview-core/public/templates/demos/demo-esri-renderer.html
line 224 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Trailing white spaces
Done
Description
Created a demo page for converting an ESRI renderer object into a GeoView layerStyle. Demo shows just the converted style, or the style in a layer configuration if a Service URL is given.
Fixes # 2673
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Path to access: Main -> Demos / Specific Demos Pages -> Custom Renderer / ESRI Renderer
ESRI Renderer Demo Page
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is