Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2673 ESRI Renderer to GeoView Style Demo Page #2731

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MatthewMuehlhauserNRCan
Copy link
Member

@MatthewMuehlhauserNRCan MatthewMuehlhauserNRCan commented Feb 4, 2025

Description

Created a demo page for converting an ESRI renderer object into a GeoView layerStyle. Demo shows just the converted style, or the style in a layer configuration if a Service URL is given.

Fixes # 2673

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Path to access: Main -> Demos / Specific Demos Pages -> Custom Renderer / ESRI Renderer
ESRI Renderer Demo Page

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2 and @MatthewMuehlhauserNRCan)


packages/geoview-core/public/templates/demos/demo-esri-renderer.html line 83 at r1 (raw file):

    }

    .line-numbers span::before {

We have a style.css file in public css to handle demo pages style. Is it copy paste from another page were we did not use the style css?


packages/geoview-core/public/templates/demos/demo-esri-renderer.html line 224 at r1 (raw file):

      }
    }
    

Trailing white spaces

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @DamonU2 and @MatthewMuehlhauserNRCan)


packages/geoview-core/public/templates/demos/demo-esri-renderer.html line 140 at r1 (raw file):

            If a Feature Service URL is provided, then a layer config with the style included will be generated.
          <br>
          Example: <i>https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/earthquakes_en/MapServer/0</i>

Can you add few test url (simple, unique value, class break.) This url as unique value but return simple https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/historical_flood_event_en/MapServer/0

Copy link
Member Author

@MatthewMuehlhauserNRCan MatthewMuehlhauserNRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @DamonU2 and @jolevesq)


packages/geoview-core/public/templates/demos/demo-esri-renderer.html line 83 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

We have a style.css file in public css to handle demo pages style. Is it copy paste from another page were we did not use the style css?

I took a copy of the Config Sandbox. It looks like it links to the style.css, but still has all the style in the style tag. That said, the "line-number" class styles are missing from the style.css. Should I add them?


packages/geoview-core/public/templates/demos/demo-esri-renderer.html line 140 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Can you add few test url (simple, unique value, class break.) This url as unique value but return simple https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/historical_flood_event_en/MapServer/0

Done


packages/geoview-core/public/templates/demos/demo-esri-renderer.html line 224 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Trailing white spaces

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants