Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] data table: canvas element conversion happening for every feature #2719

Open
1 task done
DamonU2 opened this issue Jan 29, 2025 · 0 comments · Fixed by #2738
Open
1 task done

[BUG] data table: canvas element conversion happening for every feature #2719

DamonU2 opened this issue Jan 29, 2025 · 0 comments · Fixed by #2738

Comments

@DamonU2
Copy link
Member

DamonU2 commented Jan 29, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Each row in the data table is calling toDataUrl on the canvas element representing its icon (currently data-table.tsx line 370), causing most of the delay in displaying the data table after the fetch is complete.

Expected Behavior

Either directly display the canvas element, or call toDataUrl once for each version of the icon and cache/look up.

Steps To Reproduce

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment