Caroline Cariste: Sprint Challenge Complete #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kamalnrf
reviewed
Nov 22, 2018
There was a problem hiding this comment.
✔️ What went well:
- I like the function you wrote for errors
- Migrations and seeds are also good
- Commit messages are also good
🎗️ Recommendation(s):
- Instead of having duplicate code for bad requests you can write a middleware to do that work.
- It is better to isolate all your explicit database changes in a different file like
dataHelper.jsso your API code looks cleaner and easy to maintain. - Use a logger like morgan or any other
| @@ -2,16 +2,32 @@ | |||
|
|
|||
| ## What is Node.js? | |||
|
|
|||
| * Node.js is a JavaScript run-time environment that includes everything you need to execute a program written in JavaScript. It allows JS to run within the browser. | |||
There was a problem hiding this comment.
Node.js allows JS to run outside of the browser
|
|
||
| module.exports = router; | ||
|
|
||
| const sendUserError = (msg, res) => { |
There was a problem hiding this comment.
I like this, you could have written a middleware instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.