Add Circuit.has_implicit_wireswaps property
#1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Feb 10, 2025
pytket/docs/changelog.rst
Outdated
| @@ -9,6 +9,7 @@ Features: | |||
| * Add Python 3.13 support to the ZX module. | |||
| * Add :py:meth:`QubitPauliOperator.get_dict` method. | |||
| * Add :py:meth:`Circuit.add_circuit_with_map` method. | |||
| * Add :py:attr:`Circuit.has_implicit_wireswaps` property. | |||
There was a problem hiding this comment.
This should be under a new "Unreleased" heading above please.
pytket/tests/predicates_test.py
Outdated
| assert c.has_implicit_wireswaps | ||
|
|
||
| # Property should be read-only | ||
| with pytest.raises(AttributeError): |
There was a problem hiding this comment.
It seems that a linter is complaining that this line is unreachable; I don't really see why...
There was a problem hiding this comment.
This seems to be a known mypy issue. I added an ignore comment; mypy now says the file is OK on my machine but I am not 100% sure this will fix the CI.
cqc-alec
reviewed
Feb 10, 2025
|
Made #1774 to silence the ruff warning. (Only the latest version of ruff detected this.) |
cqc-alec
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Circuit::has_implicit_wireswaps()Circuit.implicit_qubit_permutation()if the test only used the result to check for non-trivial permutationsRelated issues
Closes #1665.
Checklist