Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Circuit.add_circuit_with_map() to docs. #1767

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Add Circuit.add_circuit_with_map() to docs. #1767

merged 2 commits into from
Feb 5, 2025

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Feb 5, 2025 •
edited
Loading

Drive-by: Fix mypy issues following update of mypy to 1.15.0.

@cqc-alec cqc-alec requested a review from CalMacCQ February 5, 2025 10:37
@cqc-alec cqc-alec marked this pull request as ready for review February 5, 2025 10:37
CalMacCQ
CalMacCQ approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@CalMacCQ CalMacCQ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

The way the circuit class docs are structured isn't ideal. maybe there would be a way to catch these omissions automatically. We have a python script in the docs directory but it isn't run in C.I. currently.

@cqc-alec cqc-alec merged commit 4add312 into main Feb 5, 2025
30 checks passed
@cqc-alec cqc-alec deleted the ae/addcircdoc branch February 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMacCQ CalMacCQ CalMacCQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqc-alec @CalMacCQ