Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix minus sign in gen_term_sequence_circuit docstring #1760

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

CalMacCQ
Copy link
Contributor

@CalMacCQ CalMacCQ commented Jan 28, 2025

Description

Pretty sure this gen_term_sequence_circuit docstring contains a minus sign error as of v.1.39.0.

Screenshot 2025-01-28 at 17 54 34

I think it should be $e^{-i \frac{\pi}{2} P}$ rather than $e^{i \frac{\pi}{2} P}$.

PauliExpBox is used internally by this function which uses the following convention according to the optype documentation

Screenshot 2025-01-28 at 17 52 04

@CalMacCQ CalMacCQ requested a review from cqc-alec January 28, 2025 17:55
@CalMacCQ CalMacCQ changed the title docs: fix minus sign mistake in gen_term_sequence_circuit docstring docs: fix minus sign in gen_term_sequence_circuit docstring Jan 28, 2025
@CalMacCQ CalMacCQ merged commit 111655b into main Jan 29, 2025
30 checks passed
@CalMacCQ CalMacCQ deleted the docs/typo branch January 29, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants