feat: add QubitPauliOperator.get_dict
#1755
Conversation
pytket/tests/utils_test.py
Outdated
| qps1 = QubitPauliString(Qubit(0), Pauli.Y) | ||
| qps2 = QubitPauliString(Qubit(0), Pauli.X) | ||
| op = QubitPauliOperator({qps1: 1j, qps2: 0.5}) | ||
| assert op.get_dict() == op._dict |
There was a problem hiding this comment.
This is maybe a bit cheeky. I could do the explcit comparision if prefferred.
There was a problem hiding this comment.
Yes I think we should do an explicit comparison, to be safe against future surprises.
pytket/tests/utils_test.py
Outdated
| qps1 = QubitPauliString(Qubit(0), Pauli.Y) | ||
| qps2 = QubitPauliString(Qubit(0), Pauli.X) | ||
| op = QubitPauliOperator({qps1: 1j, qps2: 0.5}) | ||
| assert op.get_dict() == op._dict |
There was a problem hiding this comment.
Yes I think we should do an explicit comparison, to be safe against future surprises.
Co-authored-by: Alec Edgington <[email protected]>
| @@ -22,7 +22,7 @@ | |||
| from hypothesis import HealthCheck, given, settings, strategies | |||
| from hypothesis.strategies._internal import SearchStrategy | |||
| from simulator import TketSimBackend, TketSimShotBackend # type: ignore | |||
| from sympy import symbols | |||
| from sympy import I, symbols | |||
There was a problem hiding this comment.
I noticed that pylint doesn't seem to detect the unused imports here
Dict, List, Tuple are not used.
There was a problem hiding this comment.
Ah, this is because we disable https://docs.astral.sh/ruff/rules/unused-import/ (F401) in the ruff.toml file. I disabled it because I wanted to allow unused imports in init files, but it would be good to disallow them in other files. Will make an issue to fix this.
| @@ -22,7 +22,7 @@ | |||
| from hypothesis import HealthCheck, given, settings, strategies | |||
| from hypothesis.strategies._internal import SearchStrategy | |||
| from simulator import TketSimBackend, TketSimShotBackend # type: ignore | |||
| from sympy import symbols | |||
| from sympy import I, symbols | |||
There was a problem hiding this comment.
Ah, this is because we disable https://docs.astral.sh/ruff/rules/unused-import/ (F401) in the ruff.toml file. I disabled it because I wanted to allow unused imports in init files, but it would be good to disallow them in other files. Will make an issue to fix this.
Description
Please summarise the changes.
Minor change adding a
get_dictexport forQubitPauliOperator. This avoids having to used the undocumented private_dictattribute`Using
.get_dictas opposed toto_dicthere as this new method is not intended for json serialisation.Related issues
Please mention any github issues addressed by this PR.
Checklist