Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompose boxes inside conditionals #1746

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Decompose boxes inside conditionals #1746

merged 4 commits into from
Jan 22, 2025

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Jan 22, 2025 •
edited
Loading

Fixes #1583 .

@cqc-alec cqc-alec changed the title Ae/decompnestedcc Decompne boxes inside conditionals Jan 22, 2025
@cqc-alec cqc-alec changed the title Decompne boxes inside conditionals Decompose boxes inside conditionals Jan 22, 2025
@cqc-alec cqc-alec requested a review from sjdilkes January 22, 2025 14:47
@cqc-alec cqc-alec marked this pull request as ready for review January 22, 2025 14:47
sjdilkes
sjdilkes approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sjdilkes sjdilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjdilkes sjdilkes mentioned this pull request Jan 22, 2025
Closed
@cqc-alec cqc-alec merged commit c69721d into main Jan 22, 2025
32 checks passed
@cqc-alec cqc-alec deleted the ae/decompnestedcc branch January 22, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjdilkes sjdilkes sjdilkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DecomposeBoxes doesn't decompose CircBox with nested classical control
2 participants
@cqc-alec @sjdilkes